ODSC-88491: Fix conda environment resolution for slug versus full OCI path inputs#1393
Open
cheryloracle wants to merge 2 commits into
Open
ODSC-88491: Fix conda environment resolution for slug versus full OCI path inputs#1393cheryloracle wants to merge 2 commits into
cheryloracle wants to merge 2 commits into
Conversation
cheryloracle
requested review from
mrDzurb,
sambitkumohanty and
smfirmin
as code owners
July 7, 2026 17:14
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
smfirmin
approved these changes
Jul 7, 2026
cheryloracle
force-pushed
the
csa/odsc-88491
branch
from
July 8, 2026 17:05
fb4b06b to
e41acb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed ADS conda environment resolution so slug inputs and full OCI conda paths follow separate resolution paths. Short service conda slugs resolve through the service conda index and now fail with explicit slug-specific guidance to use the full Environment Explorer path when unresolved. Full oci:// conda paths are treated as authoritative: they validate object accessibility directly, avoid service_pack/index.json lookup, preserve the original runtime path metadata, and classify custom published paths as published unless the path itself is an explicit service conda bucket/path. Regression tests now assert slug guidance, full-path published metadata, no service-index lookup for full paths, and path-specific validation failures for both training and inference env info.
Tests Run
/tmp/ads-py314-core-venv/bin/python -m pytest tests/unitary/with_extras/model/test_env_info.py::TestTrainingEnvInfo::test_from_slug_not_exist tests/unitary/with_extras/model/test_env_info.py::TestTrainingEnvInfo::test_from_slug_service_pack_list_not_extracted tests/unitary/with_extras/model/test_env_info.py::TestInferenceEnvInfo::test_from_slug_not_exist tests/unitary/with_extras/model/test_env_info.py::TestInferenceEnvInfo::test_from_slug_service_pack_list_not_extracted -q (passed: 4 tests)
/tmp/ads-py314-core-venv/bin/python -m pytest tests/unitary/with_extras/model/test_env_info.py::TestTrainingEnvInfo::test_from_path_cp tests/unitary/with_extras/model/test_env_info.py::TestTrainingEnvInfo::test_from_path_not_accessible tests/unitary/with_extras/model/test_env_info.py::TestInferenceEnvInfo::test_from_path_custom_pack tests/unitary/with_extras/model/test_env_info.py::TestInferenceEnvInfo::test_from_path_not_accessible -q (passed: 4 tests)
/tmp/ads-py314-core-venv/bin/python -m pytest tests/unitary/with_extras/model/test_env_info.py::TestTrainingEnvInfo::test_from_slug_dev_sp tests/unitary/with_extras/model/test_env_info.py::TestTrainingEnvInfo::test_from_slug_prod_sp tests/unitary/with_extras/model/test_env_info.py::TestTrainingEnvInfo::test_from_slug_not_exist tests/unitary/with_extras/model/test_env_info.py::TestTrainingEnvInfo::test_from_slug_service_pack_list_not_extracted tests/unitary/with_extras/model/test_env_info.py::TestTrainingEnvInfo::test_from_path_cp tests/unitary/with_extras/model/test_env_info.py::TestTrainingEnvInfo::test_from_path_not_accessible tests/unitary/with_extras/model/test_env_info.py::TestInferenceEnvInfo::test_from_slug_dev_sp tests/unitary/with_extras/model/test_env_info.py::TestInferenceEnvInfo::test_from_slug_prod_sp tests/unitary/with_extras/model/test_env_info.py::TestInferenceEnvInfo::test_from_slug_not_exist tests/unitary/with_extras/model/test_env_info.py::TestInferenceEnvInfo::test_from_slug_service_pack_list_not_extracted tests/unitary/with_extras/model/test_env_info.py::TestInferenceEnvInfo::test_from_path_custom_pack tests/unitary/with_extras/model/test_env_info.py::TestInferenceEnvInfo::test_from_path_not_accessible -q (passed: 12 tests)
/tmp/ads-py314-core-venv/bin/python -m pytest tests/unitary/with_extras/model/test_env_info.py -q (failed: test_get_service_packs_bad_response due local OCI auth config/default signer; 24 passed)
/tmp/ads-py314-core-venv/bin/python -m pytest tests/unitary/with_extras/model/test_artifact.py -q (blocked: ModuleNotFoundError: No module named 'skl2onnx')