Skip to content

Fix conda slug and full path resolution#1391

Merged
mrDzurb merged 4 commits into
mainfrom
ODSC-88491/conda-path-resolution
Jul 7, 2026
Merged

Fix conda slug and full path resolution#1391
mrDzurb merged 4 commits into
mainfrom
ODSC-88491/conda-path-resolution

Conversation

@mrDzurb

@mrDzurb mrDzurb commented Jul 3, 2026

Copy link
Copy Markdown
Member

Summary

Fixes conda environment resolution so service conda lookup is only used for short slug inputs, while full oci://... paths are handled directly.

Changes

  • Route full OCI conda paths through EnvInfo.from_path() without reading service_pack/index.json.
  • Validate full OCI conda paths directly and return path-specific errors.
  • Keep valid service conda slug resolution unchanged.
  • Return clearer errors when:
    • the service conda list cannot be extracted
    • a provided slug is not a service conda slug
  • Preserve custom published conda paths as published.
  • Pass auth through full-path resolution.
  • Add regression coverage for slug failures and full-path routing.

Validation

  • tests/unitary/with_extras/model/test_env_info.py -q: 24 passed
  • python -m py_compile on changed files: passed
  • git diff --check: passed

Notes

test_artifact.py could not be collected in the local venv because skl2onnx is not installed, but the changed file compiles cleanly.

@mrDzurb
mrDzurb requested a review from skjoracle July 3, 2026 17:00
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 3, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

📌 Cov diff with main:

Coverage-42%

📌 Overall coverage:

Coverage-61.10%

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

📌 Cov diff with main:

Coverage-95%

📌 Overall coverage:

Coverage-62.70%

@mrDzurb
mrDzurb merged commit 0d47b5b into main Jul 7, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants