Skip to content

System: Access: Tester: convert to MVC - #10071

Open
sopex wants to merge 3 commits into
opnsense:masterfrom
sopex:pr-diag_authentication
Open

System: Access: Tester: convert to MVC#10071
sopex wants to merge 3 commits into
opnsense:masterfrom
sopex:pr-diag_authentication

Conversation

@sopex

@sopex sopex commented Apr 1, 2026

Copy link
Copy Markdown
Member
image

Closes: #10073

@Monviech

Monviech commented Apr 1, 2026

Copy link
Copy Markdown
Member

Offering a PR right away skips the triage, discussion and design phase.

I would recommend opening an issue first, ask for opinions, and starting to work on something after some initial discussion took place.

Skipping ahead in the process is not even something that I do myself too often, because planning is too important.

Check out how I usually approach things, I create issues, brainstorm a bit, see what kind of opinions I get, and slowly scope out the implementation.

I know that easy wins feel good, yet sticking to a well established process inside this repository benefits everybody.

I'm not shooting this down btw, leave it open, I just wanted to give general pointers how collaboration can be improved.

@sopex

sopex commented Apr 1, 2026

Copy link
Copy Markdown
Member Author

Would you be kind enough to open a demonstration issue for this PR so that I can better understand your suggested method of soliciting feedback?

I would really appreciate it, as I appreciate your communication comments.

@Monviech

Monviech commented Apr 1, 2026

Copy link
Copy Markdown
Member

I think something like this shows how I approach things:

#9942

An issue was created, I was assigned to it, then I did some scoping and thought about how to approach it (in the open so people can give feedback or complain).
Then I turned the issue into multiple small scoped implementation goals in following PRs until it was completed.

That's the kind of process I envision, but it also takes time. The key here is that a small issue with a small scope is created, and then assigned to somebody to work on.

Changing core infrastructure with a rewrite of a component is something that should be discussed beforehand.

A small scoped feature like the Unbound nxdomain or Dnsmasq no-ping example you did recently that has a very low footprint are usually okay as drive by contributions without deeper discussions.

@AdSchellevis AdSchellevis self-assigned this Apr 1, 2026
@sopex sopex closed this Apr 1, 2026
@sopex
sopex deleted the pr-diag_authentication branch April 1, 2026 22:05
@sopex
sopex restored the pr-diag_authentication branch April 1, 2026 22:17
@sopex sopex reopened this Apr 1, 2026
@sopex

sopex commented Apr 6, 2026

Copy link
Copy Markdown
Member Author

@AdSchellevis Have you taken a look? Obviously, no pressure, just to keep anything in mind for #10084

@sopex
sopex force-pushed the pr-diag_authentication branch from baed53e to eb424f6 Compare June 12, 2026 22:30
@sopex

sopex commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Rebase and plist fix

@sopex
sopex force-pushed the pr-diag_authentication branch from 195c488 to b3101e9 Compare September 7, 2026 07:10
@sopex
sopex force-pushed the pr-diag_authentication branch from b3101e9 to 3837d58 Compare September 7, 2026 07:12
@sopex sopex changed the title System: Access: Tester convert to MVC System: Access: Tester: convert to MVC Sep 7, 2026
@sopex

sopex commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

@AdSchellevis I know this is huge and not a priority but IMO its actually in really good shape if the need ever arises.

@AdSchellevis

Copy link
Copy Markdown
Member

@sopex when time permits I'll review the PR, but at the moment it's way to busy I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

System: Access: Tester convert to MVC

3 participants