Skip to content

fix zdb -R for raw flag#326

Open
datacore-skumar wants to merge 1 commit into
openzfsonwindows:masterfrom
DataCoreSoftware:ZFS-450
Open

fix zdb -R for raw flag#326
datacore-skumar wants to merge 1 commit into
openzfsonwindows:masterfrom
DataCoreSoftware:ZFS-450

Conversation

@datacore-skumar

Copy link
Copy Markdown

Write was returing wrong size due to some non printable characters
in buffer So, I replaced Write with putchar.

@lundman

lundman commented Jan 19, 2021

Copy link
Copy Markdown
Collaborator

Is this the sort of place that O_BINARY would affect the outcome?

Write was returing wrong size due to incorrect handle.
@datacore-skumar

Copy link
Copy Markdown
Author

The issue was with wrong file handle to WriteFile(). It's working fine after fixing the file handle.

@lundman

lundman commented Jan 20, 2021

Copy link
Copy Markdown
Collaborator

Ah yep, the sort of thing "wosix.h" is supposed to hide, but it probably isn't used for zdb. This will do fine in ZFSin, but let's take the wosix approach in the new port..

@lundman

lundman commented Feb 17, 2021

Copy link
Copy Markdown
Collaborator

What is the status here?

@imtiazdc

Copy link
Copy Markdown
Contributor

What is the status here?

@lundman This could be merged in ZFSin. We tested this internally and found it working.

@lundman

lundman commented Feb 18, 2021

Copy link
Copy Markdown
Collaborator

Ok, posix.c and wosix.h is supposed to wrap the write(_fileno(stdout), parts, with fileno going to HANDLE, and write using WriteFile(HANDLE, ... (although, its supposed to be fileno, not _fileno, since that will call Windows fileno and return a filedes.

@GAMBOT8

GAMBOT8 commented Jan 15, 2026

Copy link
Copy Markdown

Folks, I require assistance. Anyone may assist me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants