Skip to content

[chores] Made SeleniumTestMixin to use its own find_element method #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nemesifier merged 2 commits into from
Jul 14, 2026
Merged

[chores] Made SeleniumTestMixin to use its own find_element method #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64cd554
[chores] Made SeleniumTestMixin to use it's own find_element method
pandafy Jul 14, 2026
b82d078
[chores] Addressed coderabbitai's comment
nemesifier Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions openwisp_utils/tests/selenium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,26 +367,32 @@ def login(self, username=None, password=None, driver=None):
driver.get(f"{self.live_server_url}/admin/login/")
self._wait_until_page_ready(driver=driver)
if "admin/login" in driver.current_url:
driver.find_element(by=By.NAME, value="username").send_keys(username)
driver.find_element(by=By.NAME, value="password").send_keys(password)
driver.find_element(by=By.XPATH, value='//input[@type="submit"]').click()
self.find_element(by=By.NAME, value="username", driver=driver).send_keys(
username
)
self.find_element(by=By.NAME, value="password", driver=driver).send_keys(
password
)
self.find_element(
by=By.XPATH, value='//input[@type="submit"]', driver=driver
).click()
Comment thread
coderabbitai[bot] marked this conversation as resolved.
self._wait_until_page_ready(driver=driver)

def logout(self, driver=None):
driver = driver or self.web_driver
self.web_driver.find_element(By.CSS_SELECTOR, ".account-button").click()
self.web_driver.find_element(By.CSS_SELECTOR, "#logout-form button").click()
self.find_element(By.CSS_SELECTOR, ".account-button", driver=driver).click()
self.find_element(By.CSS_SELECTOR, "#logout-form button", driver=driver).click()

def find_element(self, by, value, timeout=2, driver=None, wait_for="visibility"):
driver = driver or self.web_driver
method = f"wait_for_{wait_for}"
getattr(self, method)(by, value, timeout)
getattr(self, method)(by, value, timeout, driver=driver)
return driver.find_element(by=by, value=value)

def find_elements(self, by, value, timeout=2, driver=None, wait_for="visibility"):
driver = driver or self.web_driver
method = f"wait_for_{wait_for}"
getattr(self, method)(by, value, timeout)
getattr(self, method)(by, value, timeout, driver=driver)
return driver.find_elements(by=by, value=value)

def wait_for_visibility(self, by, value, timeout=2, driver=None):
Expand Down
2 changes: 1 addition & 1 deletion requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# For testing Dependency loaders
openwisp_controller @ https://github.com/openwisp/openwisp-controller/tarball/master
openwisp_controller @ https://github.com/openwisp/openwisp-controller/archive/refs/heads/master.tar.gz
freezegun
pytest
pytest-mock
Loading