[change] Renamed is_admin label to "Organization manager" #540

[nemesifier]

Checklist

• I have read the OpenWISP Contributing Guidelines.
• I have manually tested the changes proposed in this pull request.
• I have written new test cases for new code and/or updated existing tests for changes to existing code.
• N/A I have updated the documentation.

Reference to Existing Issue

Closes #540

Description of Changes

Renamed "Is admin" to "Organization manager" for consistency with the terminology adopted in the documentation.

Screenshots

Admin:

REST API:

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 172c0e7e-d7d3-438c-97d9-8264350a1ce7

📥 Commits

Reviewing files that changed from the base of the PR and between a07658b and c627d6d.

📒 Files selected for processing (2)

• docs/user/basic-concepts.rst
• docs/user/rest-api.rst

📜 Recent review details

⏰ Context from checks skipped due to timeout. (15)

• GitHub Check: Python==3.11 | django~=5.2.0
• GitHub Check: Python==3.10 | django~=5.0.0
• GitHub Check: Python==3.13 | django~=5.2.0
• GitHub Check: Python==3.12 | django~=5.0.0
• GitHub Check: Python==3.11 | django~=4.2.0
• GitHub Check: Python==3.13 | django~=5.1.0
• GitHub Check: Python==3.12 | django~=4.2.0
• GitHub Check: Python==3.10 | django~=4.2.0
• GitHub Check: Python==3.10 | django~=5.2.0
• GitHub Check: Python==3.12 | django~=5.1.0
• GitHub Check: Python==3.11 | django~=5.0.0
• GitHub Check: Python==3.11 | django~=5.1.0
• GitHub Check: Python==3.12 | django~=5.2.0
• GitHub Check: Python==3.10 | django~=5.1.0
• GitHub Check: Analyze (python)

🔇 Additional comments (2)

docs/user/basic-concepts.rst (1)

163-189: LGTM!

docs/user/rest-api.rst (1)

268-271: LGTM!

Also applies to: 286-291, 299-304

---

📝 Walkthrough

Walkthrough

This change renames the display label of OrganizationUser.is_admin to “Organization manager” while keeping the field name and API key unchanged. The model update is mirrored by Django migrations in both the main app and sample test app. Admin forms now declare explicit field order with organization before is_admin, the serializer field order is adjusted the same way, and tests and docs are updated to reflect the new label and mapping.

Estimated code review effort: 2 (Simple) | ~10 minutes

Related Issues

Directly addresses: #540 — renames the is_admin label to “Organization manager” and places organization before is_admin in admin and API representations without changing the payload key.

Suggested labels

enhancement, admin, api

Suggested reviewers

nemesifier

Poem

🐰 A label once called “Is admin” plain and bare,
Now reads “Organization manager” with care.
Organization first, then the flag falls in line,
Migrations and tests keep the change aligned,
A rabbit hops through fields in tidy repair. 🥕

🚥 Pre-merge checks | ✅ 8

✅ Passed checks (8 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the PR’s main change and uses the required descriptive [change] prefix.
Description check	✅ Passed	The description includes the checklist, linked issue reference, change summary, and screenshots required by the template.
Linked Issues check	✅ Passed	The changes satisfy #540 by renaming the label to Organization manager and ordering organization before is_admin in admin and serializers.
Out of Scope Changes check	✅ Passed	No unrelated code changes are evident; the edits stay within the label rename, ordering, tests, docs, and migration scope.
Bug Fixes	✅ Passed	Root cause fixed in model/admin/serializer; regression tests cover label and ordering and would fail without the patch. Warning: UI change lacks a Selenium browser test.
Features	✅ Passed	Issue #540 exists and is labeled/assigned; docs and tests cover the change, and the PR description includes screenshots.
Changes	✅ Passed	Docs were updated, UI screenshots are included in the PR description, tests cover the new label/order, and the API key stays is_admin so behavior remains backward compatible.
General Rules	✅ Passed	Issue #540 has an enhancement label and is in OpenWISP Priorities; code renames the label with gettext and adds ordering/tests/docs updates, with no obvious security/performance issues.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch organization-managers

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coveralls]

coverage: 98.131% (+0.003%) from 98.128% — organization-managers into master