Skip to content

[chores] Separated session redis bucket from cache bucket#307

Open
nemesifier wants to merge 2 commits into
masterfrom
separate-session-storage
Open

[chores] Separated session redis bucket from cache bucket#307
nemesifier wants to merge 2 commits into
masterfrom
separate-session-storage

Conversation

@nemesifier

Copy link
Copy Markdown
Member

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • N/A I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • N/A I have updated the documentation.

Reference to Existing Issue

Not needed, small improvement being done in all repositories.

Description of Changes

Small improvement to the test env which separates cache from session storage to avoid terminating sessions when clearing the cache.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nemesifier, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 3 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 95fc2d22-7aaf-46d8-b9d9-6bb18490a9b7

📥 Commits

Reviewing files that changed from the base of the PR and between 2f23a6c and 4bacb85.

📒 Files selected for processing (1)
  • tests/openwisp2/settings.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch separate-session-storage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openwisp-companion

Copy link
Copy Markdown

Test Failures in Network Topology

Hello @nemesifier,
(Analysis for commit 7d20dcf)

There are multiple test failures related to query counts and an AssertionError in test_change_strategy_fetch_api_200.

  1. Test Failure: test_change_strategy_fetch_api_200
  • Failure: AssertionError: 11 != 12 : 11 queries executed, 12 expected
  • Reason: The test expects 12 SQL queries but only 11 were executed. This indicates a potential issue with how the test is set up or an unexpected query behavior.
  • Fix: Review the test case openwisp_network_topology/tests/test_api.py around line 483 to understand why the query count differs and adjust either the test's expectation or the code's query behavior.
  1. Test Failures: Query Count Mismatches
  • test_link_change_list_queries (in test_admin.py and test_integration.py): AssertionError: 4 != 5 : 4 queries executed, 5 expected
  • test_node_change_list_queries (in test_admin.py and test_integration.py): AssertionError: 4 != 5 : 4 queries executed, 5 expected
  • Reason: These tests are asserting a specific number of queries, but the actual number of queries executed by the code differs.
  • Fix: Examine the code in openwisp_network_topology/tests/test_admin.py and openwisp_network_topology/tests/test_integration.py around the failing test methods. Adjust the expected query count in the tests or optimize the code to match the expected query count.
  1. Test Failure: test_topology_receive_no_key_create_api
  • Failure: AttributeError: Can't get local object 'convert_exception_to_response.<locals>.inner'
  • Reason: This error often indicates an issue with how exceptions are handled or serialized within the test environment, possibly related to pickling or serialization of internal objects.
  • Fix: This error is harder to pinpoint without more context. It might be related to changes in Django's exception handling or how subTest is used. Review the test in openwisp_network_topology/tests/test_api.py and consider if there are any recent changes in Django or related libraries that might affect this. It might also be a transient issue.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 98.871%. remained the same — separate-session-storage into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants