Skip to content

[chores] Standardized REST API pagination #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nemesifier merged 2 commits into from
Jun 1, 2026
+3 −8
Merged

[chores] Standardized REST API pagination #217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
638b55e
[chores] Standardized REST API pagination
nemesifier May 29, 2026
638a521
Merge branch 'master' into utils-pagination
nemesifier Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions openwisp_ipam/api/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
FilterByParentManaged,
ProtectedAPIMixin as BaseProtectedAPIMixin,
)
from openwisp_utils.api.pagination import OpenWispPagination
from rest_framework import pagination, serializers, status
from rest_framework.generics import (
CreateAPIView,
Expand Down Expand Up @@ -48,12 +49,6 @@ class ProtectedAPIMixin(BaseProtectedAPIMixin):
throttle_scope = "ipam"


class ListViewPagination(pagination.PageNumberPagination):
page_size = 10
page_size_query_param = "page_size"
max_page_size = 100


class HostsListPagination(pagination.BasePagination):
limit = 256
start_query_param = "start"
Expand Down Expand Up @@ -178,7 +173,7 @@ class IpAddressListCreateView(IpAddressOrgMixin, ProtectedAPIMixin, ListCreateAP
queryset = IpAddress.objects.none()
subnet_model = Subnet
serializer_class = IpAddressSerializer
pagination_class = ListViewPagination
pagination_class = OpenWispPagination

def get_queryset(self):
subnet = get_object_or_404(self.subnet_model, pk=self.kwargs["subnet_id"])
Expand All @@ -190,7 +185,7 @@ class SubnetListCreateView(
FilterByOrganizationManaged, ProtectedAPIMixin, ListCreateAPIView
):
serializer_class = SubnetSerializer
pagination_class = ListViewPagination
pagination_class = OpenWispPagination
queryset = Subnet.objects.all().order_by("subnet")


Expand Down
Loading