Skip to content

[fix] Trigger changelog bot for backward incompatible changes#215

Merged
nemesifier merged 2 commits into
masterfrom
changelog-bot-change-bang
Jun 15, 2026
Merged

[fix] Trigger changelog bot for backward incompatible changes#215
nemesifier merged 2 commits into
masterfrom
changelog-bot-change-bang

Conversation

@nemesifier

Copy link
Copy Markdown
Member

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

No existing issue.

Description of Changes

This PR updates the changelog bot trigger workflow to match PR titles starting with [change!].

This allows backward incompatible PRs to run the reusable changelog workflow after maintainer approval, the same as [feature], [fix], and [change] PRs.

Screenshot

Not applicable.

Update the changelog bot trigger so PR titles marked with [change!] run the reusable changelog workflow.
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 57180b34-2bca-40bb-887e-541c6515027b

📥 Commits

Reviewing files that changed from the base of the PR and between a4b2724 and ebc2a3e.

📒 Files selected for processing (1)
  • .github/workflows/bot-changelog-trigger.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Python==3.11 | django~=5.2.0
  • GitHub Check: Python==3.10 | django~=4.2.0
  • GitHub Check: Python==3.12 | django~=4.2.0
  • GitHub Check: Python==3.12 | django~=5.1.0
  • GitHub Check: Python==3.10 | django~=5.1.0
  • GitHub Check: Python==3.12 | django~=5.2.0
  • GitHub Check: Python==3.10 | django~=5.2.0
🔇 Additional comments (1)
.github/workflows/bot-changelog-trigger.yml (1)

23-23: LGTM!


📝 Walkthrough

Walkthrough

The GitHub Actions workflow .github/workflows/bot-changelog-trigger.yml is updated to extend the regular expression used in the "Check for noteworthy PR" step. The regex now matches PR titles starting with [change!] in addition to the previously supported [change], [feature], and [fix] prefixes. No other workflow logic is modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title follows the required format with [fix] prefix and clearly describes the main change of updating the changelog bot to recognize backward incompatible change markers.
Description check ✅ Passed The PR description covers most required sections with a clear explanation of changes, though test cases and documentation updates were not completed as indicated by unchecked boxes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Bug Fixes ✅ Passed The check for bug fixes is not applicable; this PR is a feature enhancement to a GitHub Actions workflow, not a bug fix in core user-facing functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch changelog-bot-change-bang

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot

kilo-code-bot Bot commented May 26, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • .github/workflows/bot-changelog-trigger.yml - Simple regex update to match [change!] PR titles

The change correctly adds optional exclamation mark support (change!?) to allow backward incompatible changes ([change!]) to trigger the changelog bot workflow.


Reviewed by kimi-k2.5-0127 · 83,984 tokens

@openwisp-companion

Copy link
Copy Markdown

Test Failures: Missing freezegun Module

Hello @nemesifier,
(Analysis for commit bbb49e6)

There are test failures due to a missing freezegun module. This module is required for mocking time in tests, specifically in openwisp_users.tests.test_admin.

Fix:
Add freezegun to your project's dependencies (e.g., in requirements.txt or pyproject.toml) and ensure it is installed in your environment.

@openwisp-companion

Copy link
Copy Markdown

No Failures Detected

Hello @nemesifier,
(Analysis for commit bbb49e6)

No failures were detected in the CI logs.

@openwisp-companion

Copy link
Copy Markdown

Test Failures in Multiple Python Versions

Hello @nemesifier,
(Analysis for commit bbb49e6)

  • Test Failure: ModuleNotFoundError: No module named 'freezegun'
    The tests in openwisp_ipam.tests.test_users_integration are failing because the freezegun library is not found.
    Fix: Add freezegun to your project's dependencies (e.g., in requirements.txt or setup.py).

  • Build Failure: Migrations check failed
    The SAMPLE_APP tests are failing because there are unapplied migrations.
    Fix: Run ./manage.py makemigrations to create the necessary migration files.

@nemesifier
nemesifier merged commit 9cba6ae into master Jun 15, 2026
19 checks passed
@nemesifier
nemesifier deleted the changelog-bot-change-bang branch June 15, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant