Skip to content

[fix] Retry registration on transient controller 5xx errors #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaelUray wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix] Retry registration on transient controller 5xx errors #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions openwisp-config/files/openwisp.agent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,17 @@ register() {
-p daemon.err
return 1
fi
# A transient server-side error (HTTP 5xx, e.g. 502/503/504 from a reverse
# proxy while the backend is restarting) carries no X-Openwisp-Controller
# header. Without this guard check_header below would treat it as a wrong
# server and call `exit 4`, killing the agent for good once procd's respawn
# limit is exhausted. Treat 5xx as a temporary failure and retry instead.
if head -n 1 "$REGISTRATION_PARAMETERS" | tr -d '\r' | grep -qE "^HTTP/[0-9.]+ 5[0-9][0-9]( |$)"; then
logger -s "Registration temporarily failed (controller returned 5xx), will retry: $(head -n 1 "$REGISTRATION_PARAMETERS" | tr -d '\r')" \
-t openwisp \
-p daemon.warning
return 2
fi
# exit if response does not seem to come from openwisp controller
check_header $REGISTRATION_PARAMETERS
if ! is_http_status $REGISTRATION_PARAMETERS 201; then
Expand Down