[chores] Added firmware upgrader websocket routes #534#625
Merged
Conversation
Added conditional inclusion of websocket routes from openwisp_firmware_upgrader.routing.get_routes() in the Channels routing.py template, gated behind the openwisp2_firmware_upgrader variable. This is required to support real-time upgrade progress tracking via WebSockets, introduced in openwisp/openwisp-firmware-upgrader#320. Closes #534
📝 WalkthroughWalkthroughThis PR adds conditional integration of firmware upgrader websocket routes to the routing template. When the Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
nemesifier
approved these changes
Jun 5, 2026
|
Proposed change log entry: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #534
Description of Changes
Added conditional inclusion of websocket routes from openwisp_firmware_upgrader.routing.get_routes() in the Channels routing.py template, gated behind the openwisp2_firmware_upgrader variable.
This is required to support real-time upgrade progress tracking via WebSockets, introduced in openwisp/openwisp-firmware-upgrader#320.