Reset NFC state after engagement errors - #1989
Closed
JustCallMeC wants to merge 3 commits into
Closed
Conversation
…entialInvalidException in CredentialData when referencing a deleted KeyStore key.
…t errors. Signed-off-by: Chandan Aubel <123573557+JustCallMeC@users.noreply.github.com>
davidz25
previously approved these changes
Sep 8, 2026
JustCallMeC
marked this pull request as ready for review
September 8, 2026 23:49
Contributor
|
Sorry, I didn't realize this was three commits until after I reviewed it. |
davidz25
dismissed
their stale review
September 8, 2026 23:51
I didn't realize it was three commits until after I approved it.
Contributor
|
I think there should just be a single commit here. Also please reference the issue you filed to satisfy the "Require Linked Issue" check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When NFC engagement encounters an error (such as non-OK status on NDEF select or capability container selection), the transceiverThread currently reports the error without releasing or closing the underlying IsoDep instance and resetting nfcIsoDep. This leaves the NFC reader in a wedged state where subsequent NFC taps fail to connect. This adds a block to ensure IsoDep is closed and nfcIsoDep is reset to null after completion or failure.