Skip to content

WIP: Alpine and basic IPv6 - #2

Open
RoadRunnr wants to merge 2 commits into
openvnf:masterfrom
RoadRunnr:master
Open

WIP: Alpine and basic IPv6#2
RoadRunnr wants to merge 2 commits into
openvnf:masterfrom
RoadRunnr:master

Conversation

@RoadRunnr

Copy link
Copy Markdown

No description provided.

RoadRunnr added 2 commits June 1, 2018 11:54
FRR zebra might have some advantages, but I don't see that we
actually need them.
FRR also has support for Alpine, so it might be an option to
use that later.
Comment thread entry-bgp.sh
done
fi

if [ -n "$BGP_IPV6" -o "$BGP_IPV6" = yes ]; then

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition evaluates to true for BGP_IPV6=no (which is probably not intended).
Also -n $x is always true when $x = foo this "or" makes no sense.

Comment thread CHANGELOG.md
## 1.6.0 / 2018-xx-xx

* Switch to Alpine for smaller images
* Switch to Quagga or Zebra deamon

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to add a note regarding zapi version change from 4 to 3. Last time I had trouble with version < 4 with gobgp.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zebra protocol version 4 seems to specific to the FRR version. The "original" Zebra seem to support only 0 and 1, while Quagga adds version 3.

The only reason I changed this to Quagga is that there a Alpine packages for Quagga. FRR has been working on Alpine packages as well, but they are somewhat WIP (https://github.com/FRRouting/frr/commits/master/alpine).

It might make sense investigate if the FRR apline packages can be integrated instead of the Quagga ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants