Skip to content

Changing verification clients - #113

Merged
hrishiballal merged 2 commits into
mainfrom
rename-session-id-for-sdsp
Apr 5, 2026
Merged

Changing verification clients#113
hrishiballal merged 2 commits into
mainfrom
rename-session-id-for-sdsp

Conversation

@hrishiballal

Copy link
Copy Markdown
Contributor

This PR changes the verification repo to accommodate changes proposed at: openutm/flight-blender#85

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the verification repo’s SDSP-related steps and scenarios to match the updated Flight Blender API/client naming (aligning with openutm/flight-blender#85), primarily by renaming the SDSP session identifier argument.

Changes:

  • Renamed SDSP step argument session_idsurveillance_session_id across the FlightBlender client step methods.
  • Updated YAML scenarios and scenario documentation to use the new argument name.
  • Updated unit tests to call/assert the new keyword argument.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_client_steps.py Updates SDSP-related test calls/assertions to use surveillance_session_id.
src/openutm_verification/core/clients/flight_blender/flight_blender_client.py Renames SDSP session parameter in step methods and websocket initializers to surveillance_session_id.
scenarios/sdsp-f3623/verify_sdsp_metrics.yaml Updates Start/Stop SDSP Session arguments to surveillance_session_id.
scenarios/sdsp-f3623/sdsp_track.yaml Updates SDSP Track scenario arguments to surveillance_session_id.
scenarios/sdsp-f3623/sdsp_heartbeat.yaml Updates SDSP Heartbeat scenario arguments to surveillance_session_id.
scenarios/README.md Updates documented YAML examples to use surveillance_session_id.
Comments suppressed due to low confidence (1)

src/openutm_verification/core/clients/flight_blender/flight_blender_client.py:1161

  • The docstring for start_stop_sdsp_session is now out of sync with the function signature/behavior: it still refers to session_id (and mentions validating it), and the Returns: section says bool even though the step returns a message string (wrapped into StepResult by @scenario_step). Update the docstring to use surveillance_session_id and describe the actual return value (or adjust the implementation/type hints if the intention is to return a boolean).
    async def start_stop_sdsp_session(self, surveillance_session_id: str, action: SDSPSessionAction) -> str:
        """
        Starts or stops an SDSP (Strategic Deconfliction Service Provider) session based on the specified action.
        This method interacts with the Flight Blender service to manage the lifecycle of an SDSP session.
        It can be used to initiate a new session or terminate an existing one.
        Args:
            session_id (str): The unique identifier of the SDSP session to start or stop.
            action (SDSPSessionAction): The action to perform on the session, such as START or STOP.
        Returns:
            bool: True if the action was successfully performed, False otherwise.
        Raises:
            ValueError: If the session_id is invalid or the action is not supported.
            ConnectionError: If there is an issue communicating with the Flight Blender service.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@atti92
atti92 self-requested a review March 30, 2026 21:09
@hrishiballal
hrishiballal merged commit b89b497 into main Apr 5, 2026
1 check passed
@hrishiballal
hrishiballal deleted the rename-session-id-for-sdsp branch April 5, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants