Refactor SDSP session handling: rename methods and update documentati… - #111
Merged
Conversation
RomanPszonka
approved these changes
Mar 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors SDSP session lifecycle handling by splitting the previously combined “Start / Stop SDSP Session” operation into two distinct operations so they can be annotated with flight phases (supporting step grouping/tagging work from #104).
Changes:
- Replaced the combined SDSP session step with
Start SDSP Session(PRE_FLIGHT) andStop SDSP Session(POST_FLIGHT). - Updated YAML scenarios and docs to use the new step names and remove the
actionargument. - Updated unit tests and scenario code to call the new client methods.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/openutm_verification/core/clients/flight_blender/flight_blender_client.py |
Introduces _sdsp_session_action helper and new phased start/stop scenario steps. |
src/openutm_verification/scenarios/test_sdsp_track_with_bluesky_sim.py |
Updates scenario code to call start_sdsp_session / stop_sdsp_session. |
scenarios/sdsp-f3623/verify_sdsp_metrics.yaml |
Migrates scenario steps to new SDSP start/stop operations. |
scenarios/sdsp-f3623/sdsp_track.yaml |
Migrates scenario steps to new SDSP start/stop operations. |
scenarios/sdsp-f3623/sdsp_heartbeat.yaml |
Migrates scenario steps to new SDSP start/stop operations. |
scenarios/README.md |
Updates example YAML and operation list to reflect new step names. |
docs/scenarios/sdsp-f3623/sdsp_track.md |
Updates documentation step names for the SDSP track scenario. |
docs/scenarios/sdsp-f3623/sdsp_heartbeat.md |
Updates documentation step names for the SDSP heartbeat scenario. |
tests/test_client_steps.py |
Splits SDSP session test into separate start and stop tests; removes enum import. |
tests/test_yaml_scenarios.py |
Updates mocks to match the new start/stop SDSP methods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate Start and Stop step for SDSP session to add phase.
#104