chore(docker): add gcloud storage to docker container#1247
Open
project-defiant wants to merge 1 commit into
Open
chore(docker): add gcloud storage to docker container#1247project-defiant wants to merge 1 commit into
project-defiant wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Context
Harmoniation and QC steps are using the docker container defined in orchestration. The container wraps gentropy container and adds two things on top:
Later the container is build via github actions from orchestration tag.
The approach described above no longer holds, as of migration to the
pipelinerepository we no longer can support tags specific to orchestration@harmonisation. This is due to the fact that the repository now needs to host tags for PTS, PIS, croissant and orchestration. To prevent additional complexity we decided to remove the harmonisation container from orchestration. This can be done, as the orchestration google batch jobs now support putting inline scripts to run through the batch tasks, which simplify the harmonisation as we can use gentropy image directly.T
🛠 What does this PR implement
🙈 Missing
🚦 Before submitting
devbranch?make test)?uv run pre-commit run --all-files)?