Fix possible end svcactions lost and missed transaction rollback on errors#141
Merged
Conversation
…ithin the same sid. - Adjusted related logic in `job_feed_instance_action.go` to include `pid` in action ID retrieval. => retrieve correct action id when actions are run with the same sid - Updated `FindInstanceActionIDFromSID` to `FindInstanceActionIDFromPidAndSID`, adding the `pid` parameter for more precise queries.
- Moved the `updateWSP` success log outside of the loop for proper execution context.
…g in `Operations` list - Added `blocking: true` for operations (`dropPending`, `getData`, `dbNow`, `updateDB`, `purgeDB`) to ensure accurate execution behavior. - Retained `blocking: false` for `updateWSP` to maintain its non-blocking behavior.
- Added rollback handling logic in `ExecTx` for failed transactions.
… logic - Added TODO comments in `base_job.go` to review whether rollback and commit calls are still required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Introduced
Transaction Logic:
ExecTx.base_job.goto evaluate rollback/commit requirements.Operation Handling:
jobFeedInstanceResourceInfooperations as blocking, except forupdateWSP(non-blocking retained for intended behavior).Logging Updates:
updateWSPsuccess within the loop.Action ID Fix:
job_feed_instance_action.goto accurately retrieve action IDs when multiplepidsexist within onesid.FindInstanceActionIDFromSIDtoFindInstanceActionIDFromPidAndSIDfor parameter clarity and accuracy.