Skip to content

feat(songLyrics v2): add explicit line end timing - #262

Open
ranokay wants to merge 3 commits into
opensubsonic:mainfrom
ranokay:songlyrics-v2-line-end
Open

feat(songLyrics v2): add explicit line end timing#262
ranokay wants to merge 3 commits into
opensubsonic:mainfrom
ranokay:songlyrics-v2-line-end

Conversation

@ranokay

@ranokay ranokay commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

line.start tells a client when a lyric line begins, but it cannot describe when the final line ends or distinguish a deliberate gap, an overlap, and an instantaneous marker. This adds an optional line.end value so enhanced lyrics clients can represent those timings without inferring them from the next line.

Compatibility

  • end uses the same track-relative millisecond timeline as start; the structured-lyrics offset applies to both values.
  • It requires start, must be greater than or equal to it, and may equal it for an instantaneous marker. Gaps and overlaps remain valid.
  • An omitted end means that the end is unknown. It does not imply the next line's start.
  • The field is available only in enhanced=true responses. Unsynced lyrics omit both timing values, while default responses and the advertised [1, 2] versions remain unchanged.

@netlify

netlify Bot commented Jul 25, 2026

Copy link
Copy Markdown

Deploy Preview for opensubsonic ready!

Name Link
🔨 Latest commit d8e41f2
🔍 Latest deploy log https://app.netlify.com/projects/opensubsonic/deploys/6a880a6c25972800084e9af5
😎 Deploy Preview https://deploy-preview-262--opensubsonic.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@ranokay ranokay changed the title feat(songLyrics): add explicit line end timing feat(songLyrics v2): add explicit line end timing Jul 25, 2026
@ranokay
ranokay marked this pull request as ready for review July 25, 2026 09:21
@Tolriq

Tolriq commented Aug 19, 2026

Copy link
Copy Markdown
Member

Its omission means the end is unknown; clients **must not** assume the line lasts until the next line starts.

If there's no end clients needs to assume things, so the wording is probably too strong.

@ranokay

ranokay commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

You're right. I was trying to distinguish an exact, source-provided end from an end inferred by the client, but yeah, must not is too restrictive.
I'll change the wording to:
Its omission means the exact end is unknown. Clients may infer a fallback end, for example from the next line's start, but should not treat it as exact source timing.

Thanks for pointing that out.

Copilot AI lite review requested due to automatic review settings August 21, 2026 08:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Tolriq
Tolriq requested review from a team August 26, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants