feat(songLyrics v2): add explicit line end timing - #262
Open
ranokay wants to merge 3 commits into
Open
Conversation
✅ Deploy Preview for opensubsonic ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
10 tasks
ranokay
marked this pull request as ready for review
July 25, 2026 09:21
This was referenced Jul 25, 2026
Member
|
If there's no end clients needs to assume things, so the wording is probably too strong. |
Contributor
Author
|
You're right. I was trying to distinguish an exact, source-provided end from an end inferred by the client, but yeah, Thanks for pointing that out. |
Tolriq
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
line.starttells a client when a lyric line begins, but it cannot describe when the final line ends or distinguish a deliberate gap, an overlap, and an instantaneous marker. This adds an optionalline.endvalue so enhanced lyrics clients can represent those timings without inferring them from the next line.Compatibility
enduses the same track-relative millisecond timeline asstart; the structured-lyrics offset applies to both values.start, must be greater than or equal to it, and may equal it for an instantaneous marker. Gaps and overlaps remain valid.endmeans that the end is unknown. It does not imply the next line's start.enhanced=trueresponses. Unsynced lyrics omit both timing values, while default responses and the advertised[1, 2]versions remain unchanged.