add graphics event handling and undefine flags support by z0Kng · Pull Request #2 · opensourcevdi/AppBasics-Virtualization-Libvirt

z0Kng · 2025-10-27T08:23:05Z

No description provided.

rafaelgieschke · 2025-11-06T13:13:57Z

Copilot · 2025-11-06T13:14:04Z

@rafaelgieschke I've opened a new pull request, #3, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull Request Overview

This PR adds support for additional libvirt domain operations and events, targeting .NET 9.0 compatibility. The changes include new native bindings for domain undefine flags and graphics events, improvements to the QEMU monitor command interface, and updated project configuration.

Key changes:

Added native bindings for domain undefine flags and graphics event callbacks
Refactored NativeVirQemu to use proper P/Invoke memory management with out parameters
Added .NET 9.0 as a target framework and updated package dependencies

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
virDomainUndefineFlagsValues.cs	New enum defining flags for domain undefine operations
VirDomainEventGraphicsPhase.cs	New enum and structs for graphics event handling
VirConnectDomainEventCallback.cs	Added callback delegate for graphics events
NativeVirQemu.cs	Refactored to static class with improved memory management
NativeVirDomain.cs	Added UndefineFlags method with flags support
NativeVirConnect.cs	Added DomainEventGraphicsRegisterAny method
LibvirtDomain.cs	Updated to use new MonitorCommand signature
IDNT.AppBasics.Virtualization.Libvirt.csproj	Added .NET 9.0 target and updated dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-06T13:38:49Z

+using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;


The imports System.Collections.Generic, System.Linq, and System.Threading.Tasks are unused in this file. Only System is needed for the [Flags] attribute. Remove the unused imports to keep the code clean.

Suggested change

using System.Collections.Generic;

using System.Linq;

using System.Threading.Tasks;

Copilot · 2025-11-06T13:38:50Z

+using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;


The imports System.Collections.Generic, System.Linq, and System.Threading.Tasks are unused in this file. Only System and System.Runtime.InteropServices are required. Remove the unused imports.

Suggested change

using System.Collections.Generic;

using System.Linq;

using System.Threading.Tasks;

Copilot · 2025-11-06T13:38:50Z

+    /// The callback signature to use when registering for an event of type VIR_DOMAIN_EVENT_ID_GRAPHICS with virConnectDomainEventRegisterAny()
+    /// </summary>
+    /// <param name="conn">virConnect connection </param>
+    /// <param name="dom">The domain on which the event occured</param>


Corrected spelling of 'occured' to 'occurred'.

Suggested change

/// <param name="dom">The domain on which the event occured</param>

/// <param name="dom">The domain on which the event occurred</param>

Copilot · 2025-11-06T13:38:51Z

+            result = Marshal.PtrToStringUTF8(resultPtr);
+
+            // Free memory allocated by libvirt
+            NativeFunctions.Free(resultPtr);


Memory allocated by libvirt should be freed using virFree (imported at line 43-44), not NativeFunctions.Free which calls the Windows C runtime's free(). Using the wrong free function can cause crashes or memory corruption. Replace with virFree(resultPtr);

Suggested change

NativeFunctions.Free(resultPtr);

virFree(resultPtr);

Copilot · 2025-11-06T13:38:51Z

+        /// </summary>
+        /// <param name="domain">pointer to a defined domain</param>
+        /// <param name="flags">an OR'ed set of virDomainUndefineFlags</param>
+        /// <returns>0 in case of success, -1 in case of error


The XML documentation comment for the return value is incomplete - it's missing the closing </returns> tag. Add </returns> at the end of line 752.

Suggested change

/// <returns>0 in case of success, -1 in case of error

/// <returns>0 in case of success, -1 in case of error</returns>

Copilot · 2025-11-06T13:38:52Z

+            result = Marshal.PtrToStringUTF8(resultPtr);
+
+            // Free memory allocated by libvirt
+            NativeFunctions.Free(resultPtr);


Replace this call with a call to managed code if possible.

Suggested change

NativeFunctions.Free(resultPtr);

virFree(resultPtr);

Copilot · 2025-11-06T13:38:52Z

+        /// <param name="ff">optional function to deallocate opaque when not used anymore</param>
+        /// <returns>t shall take a reference to it, by calling virDomainRef. The reference can be released once the object is no longer required by calling virDomainFree. Returns 0 on success, -1 on failure</returns>
+        [DllImport("libvirt-0.dll", CallingConvention = CallingConvention.Cdecl, EntryPoint = "virConnectDomainEventRegisterAny")]
+        public static extern int DomainEventGraphicsRegisterAny(IntPtr conn, IntPtr pool, VirDomainEventID eventId,


Minimise the use of unmanaged code.

Copilot · 2025-11-06T13:38:52Z

+        public static extern int UndefineFlags(IntPtr domain, VirDomainUndefineFlagsValues flags);
+
        /// <summary>


Minimise the use of unmanaged code.

Suggested change

public static extern int UndefineFlags(IntPtr domain, VirDomainUndefineFlagsValues flags);

/// <summary>

private static extern int UndefineFlags(IntPtr domain, VirDomainUndefineFlagsValues flags);

/// <summary>

/// Managed wrapper for UndefineFlags. Undefines a domain with the specified flags.

/// </summary>

/// <param name="domain">Pointer to a defined domain</param>

/// <param name="flags">An OR'ed set of virDomainUndefineFlags</param>

/// <returns>True if successful, false otherwise</returns>

public static bool UndefineDomainWithFlags(IntPtr domain, VirDomainUndefineFlagsValues flags)

{

int result = UndefineFlags(domain, flags);

return result == 0;

}

/// <summary>

Copilot · 2025-11-06T13:38:53Z

    {
-        private const int MaxStringLength = 1024;
+        [DllImport("libvirt-qemu.so.0", CallingConvention = CallingConvention.Cdecl, EntryPoint = "virDomainQemuMonitorCommand")]
+        private static extern int virDomainQemuMonitorCommand(


Minimise the use of unmanaged code.

Copilot · 2025-11-06T13:38:53Z

+        [DllImport("libvirt.so.0", CallingConvention = CallingConvention.Cdecl, EntryPoint = "virFree")]
+        private static extern int virFree(IntPtr ptr);


Minimise the use of unmanaged code.

Suggested change

[DllImport("libvirt.so.0", CallingConvention = CallingConvention.Cdecl, EntryPoint = "virFree")]

private static extern int virFree(IntPtr ptr);

z0Kng requested a review from rafaelgieschke October 27, 2025 08:23

rafaelgieschke closed this Oct 27, 2025

rafaelgieschke force-pushed the VirGraphicsStuff branch from 936dee1 to a9bcd4e Compare October 27, 2025 16:24

rafaelgieschke reopened this Oct 27, 2025

rafaelgieschke force-pushed the VirGraphicsStuff branch from 91564ca to 6733aaa Compare October 27, 2025 16:31

feat: add graphics event handling and undefine flags support

5a9992c

rafaelgieschke force-pushed the VirGraphicsStuff branch from 6733aaa to 5a9992c Compare October 27, 2025 16:35

z0Kng added 2 commits October 30, 2025 14:49

fix: update System.Drawing.Common package version to 4.7.2

897c67a

feat: add net9.0 target framework and update output directory settings

111978e

Copilot AI mentioned this pull request Nov 6, 2025

add graphics event handling and undefine flags support #3

Closed

rafaelgieschke requested a review from Copilot November 6, 2025 13:35

Copilot AI reviewed Nov 6, 2025

View reviewed changes

rafaelgieschke merged commit 111978e into virtnext Nov 6, 2025
6 checks passed

rafaelgieschke deleted the VirGraphicsStuff branch November 6, 2025 16:43

	using System.Collections.Generic;
	using System.Linq;
	using System.Threading.Tasks;

	/// <param name="dom">The domain on which the event occured</param>
	/// <param name="dom">The domain on which the event occurred</param>

	/// <returns>0 in case of success, -1 in case of error
	/// <returns>0 in case of success, -1 in case of error</returns>

		public static extern int UndefineFlags(IntPtr domain, VirDomainUndefineFlagsValues flags);

		/// <summary>

-        public static extern int UndefineFlags(IntPtr domain, VirDomainUndefineFlagsValues flags);
-        /// <summary>
+        private static extern int UndefineFlags(IntPtr domain, VirDomainUndefineFlagsValues flags);
+        /// <summary>
+        /// Managed wrapper for UndefineFlags. Undefines a domain with the specified flags.
+        /// </summary>
+        /// <param name="domain">Pointer to a defined domain</param>
+        /// <param name="flags">An OR'ed set of virDomainUndefineFlags</param>
+        /// <returns>True if successful, false otherwise</returns>
+        public static bool UndefineDomainWithFlags(IntPtr domain, VirDomainUndefineFlagsValues flags)
+        {
+            int result = UndefineFlags(domain, flags);
+            return result == 0;
+        }
+        /// <summary>

		[DllImport("libvirt.so.0", CallingConvention = CallingConvention.Cdecl, EntryPoint = "virFree")]
		private static extern int virFree(IntPtr ptr);

Uh oh!

Conversation

z0Kng commented Oct 27, 2025

Uh oh!

rafaelgieschke commented Nov 6, 2025

Uh oh!

Copilot AI commented Nov 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants