Use PIE to install valkey-glide#5
Open
adrianluna wants to merge 1 commit into
Open
Conversation
The valkey-glide PHP extension source includes <ffi.h> which requires libffi-dev, and links against protobuf which needs libprotobuf-dev. Without these the PIE install fails during make.
📝 WalkthroughWalkthroughThe php.dockerfile updates the VALKEY_GLIDE_VERSION build argument from 1.1.0 to 1.1.2, adds libprotobuf-dev and libffi-dev to the apt-get install list, and replaces the curl-download-plus-pecl-install flow for the valkey-glide extension with a pie install command. ChangesDockerfile build update
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Building valkey-glide via PIE (
pie install valkey-io/valkey-glide-php) fails with:Changes
libffi-devandlibprotobuf-devto the apt install list inphp.dockerfile.Testing
docker compose up -d --build phpcompletes successfully and the valkey-glide extension loads.Summary by CodeRabbit