Skip to content

Use PIE to install valkey-glide#5

Open
adrianluna wants to merge 1 commit into
mainfrom
fix/pie-install-libffi
Open

Use PIE to install valkey-glide#5
adrianluna wants to merge 1 commit into
mainfrom
fix/pie-install-libffi

Conversation

@adrianluna

@adrianluna adrianluna commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Building valkey-glide via PIE (pie install valkey-io/valkey-glide-php) fails with:

fatal error: ffi.h: No such file or directory

Changes

  • Added libffi-dev and libprotobuf-dev to the apt install list in php.dockerfile.

Testing

  • docker compose up -d --build php completes successfully and the valkey-glide extension loads.

Summary by CodeRabbit

  • Chores
    • Updated the PHP environment setup to a newer Valkey Glide version.
    • Added required system libraries for smoother build and installation.
    • Switched the PHP extension installation method to a more direct and reliable approach.

The valkey-glide PHP extension source includes <ffi.h> which requires
libffi-dev, and links against protobuf which needs libprotobuf-dev.
Without these the PIE install fails during make.
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The php.dockerfile updates the VALKEY_GLIDE_VERSION build argument from 1.1.0 to 1.1.2, adds libprotobuf-dev and libffi-dev to the apt-get install list, and replaces the curl-download-plus-pecl-install flow for the valkey-glide extension with a pie install command.

Changes

Dockerfile build update

Layer / File(s) Summary
Version bump and build dependencies
php.dockerfile
VALKEY_GLIDE_VERSION is bumped to 1.1.2, and libprotobuf-dev and libffi-dev are added to the apt-get install list.
Extension install method change
php.dockerfile
The valkey-glide extension install switches from curl download + pecl install of a .tgz to pie install valkey-io/valkey-glide-php:${VALKEY_GLIDE_VERSION}.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: switching valkey-glide installation to PIE.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pie-install-libffi

Comment @coderabbitai help to get the list of available commands.

@adrianluna
adrianluna requested a review from rlunar July 6, 2026 23:57
@adrianluna adrianluna changed the title fix: add libffi-dev for PIE valkey-glide build Use PIE to install valkey-glide Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant