fix: resilient SQLite seeding in setup.sh#4
Open
adrianluna wants to merge 1 commit into
Open
Conversation
The previous guard (test -f) skipped seeding when the .sqlite file existed but was empty or missing the expected table. Now we attempt a SELECT on cache_entries and only re-seed if it fails.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughModifies scripts/setup.sh to change the SQLite database seeding trigger from file-existence checking to table-existence checking via a guard query against the cache_entries table, updating spinner text accordingly. ChangesSeeding guard update
Estimated code review effort: 1 (Trivial) | ~3 minutes Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SQLite seed step in
scripts/setup.shpreviously checked only whether the.sqlitefile existed (test -f). If the file was present but empty — or created without the expected schema — seeding was silently skipped andSqliteConnectionTestwould fail.Changes
SELECT 1 FROM cache_entries LIMIT 1).Testing
./scripts/test.sh—SqliteConnectionTestnow passes even when starting from an empty.sqlitefile.Summary by CodeRabbit