-
Notifications
You must be signed in to change notification settings - Fork 0
feat(aws): add compute icons #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,10 @@ class Batch(_Compute): | |
| _icon = "batch.png" | ||
|
|
||
|
|
||
| class Bottlerocket(_Compute): | ||
| _icon = "bottlerocket.png" | ||
|
|
||
|
|
||
| class ComputeOptimizer(_Compute): | ||
| _icon = "compute-optimizer.png" | ||
|
|
||
|
|
@@ -28,6 +32,10 @@ class Compute(_Compute): | |
| _icon = "compute.png" | ||
|
|
||
|
|
||
| class Dcv(_Compute): | ||
| _icon = "dcv.png" | ||
|
|
||
|
|
||
| class EC2Ami(_Compute): | ||
| _icon = "ec2-ami.png" | ||
|
|
||
|
|
@@ -36,6 +44,10 @@ class EC2AutoScaling(_Compute): | |
| _icon = "ec2-auto-scaling.png" | ||
|
|
||
|
|
||
| class EC2AWSMicroserviceExtractorForDotNet(_Compute): | ||
| _icon = "ec2-aws-microservice-extractor-for-dot-net.png" | ||
|
|
||
|
|
||
| class EC2ContainerRegistryImage(_Compute): | ||
| _icon = "ec2-container-registry-image.png" | ||
|
|
||
|
|
@@ -48,6 +60,10 @@ class EC2ContainerRegistry(_Compute): | |
| _icon = "ec2-container-registry.png" | ||
|
|
||
|
|
||
| class EC2DbInstance(_Compute): | ||
| _icon = "ec2-db-instance.png" | ||
|
|
||
|
|
||
| class EC2ElasticIpAddress(_Compute): | ||
| _icon = "ec2-elastic-ip-address.png" | ||
|
|
||
|
|
@@ -56,6 +72,10 @@ class EC2ImageBuilder(_Compute): | |
| _icon = "ec2-image-builder.png" | ||
|
|
||
|
|
||
| class EC2InstanceWithCloudwatch(_Compute): | ||
| _icon = "ec2-instance-with-cloudwatch.png" | ||
|
|
||
|
|
||
| class EC2Instance(_Compute): | ||
| _icon = "ec2-instance.png" | ||
|
|
||
|
|
@@ -76,6 +96,18 @@ class EC2(_Compute): | |
| _icon = "ec2.png" | ||
|
|
||
|
|
||
| class EcsAnywhere(_Compute): | ||
| _icon = "ecs-anywhere.png" | ||
|
|
||
|
|
||
| class EksAnywhere(_Compute): | ||
| _icon = "eks-anywhere.png" | ||
|
|
||
|
|
||
| class EksDistro(_Compute): | ||
| _icon = "eks-distro.png" | ||
|
|
||
|
|
||
| class ElasticBeanstalkApplication(_Compute): | ||
| _icon = "elastic-beanstalk-application.png" | ||
|
|
||
|
|
@@ -88,10 +120,42 @@ class ElasticBeanstalk(_Compute): | |
| _icon = "elastic-beanstalk.png" | ||
|
|
||
|
|
||
| class ElasticContainerRegistryImage(_Compute): | ||
| _icon = "elastic-container-registry-image.png" | ||
|
|
||
|
|
||
| class ElasticContainerRegistryRegistry(_Compute): | ||
| _icon = "elastic-container-registry-registry.png" | ||
|
|
||
|
|
||
| class ElasticContainerRegistry(_Compute): | ||
| _icon = "elastic-container-registry.png" | ||
|
|
||
|
Comment on lines
+123
to
+133
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Three new classes — |
||
|
|
||
| class ElasticContainerServiceContainer1(_Compute): | ||
| _icon = "elastic-container-service-container-1.png" | ||
|
|
||
|
|
||
| class ElasticContainerServiceContainer2(_Compute): | ||
| _icon = "elastic-container-service-container-2.png" | ||
|
|
||
|
|
||
| class ElasticContainerServiceContainer3(_Compute): | ||
| _icon = "elastic-container-service-container-3.png" | ||
|
|
||
|
|
||
| class ElasticContainerServiceContainer(_Compute): | ||
| _icon = "elastic-container-service-container.png" | ||
|
|
||
|
|
||
| class ElasticContainerServiceCopiiotCli(_Compute): | ||
| _icon = "elastic-container-service-copiiot-cli.png" | ||
|
Comment on lines
+151
to
+152
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
|
|
||
| class ElasticContainerServiceEcsServiceConnect(_Compute): | ||
| _icon = "elastic-container-service-ecs-service-connect.png" | ||
|
|
||
|
|
||
| class ElasticContainerServiceServiceConnect(_Compute): | ||
| _icon = "elastic-container-service-service-connect.png" | ||
|
|
||
|
|
@@ -108,10 +172,22 @@ class ElasticContainerService(_Compute): | |
| _icon = "elastic-container-service.png" | ||
|
|
||
|
|
||
| class ElasticFabricAdapter(_Compute): | ||
| _icon = "elastic-fabric-adapter.png" | ||
|
|
||
|
|
||
| class ElasticKubernetesServiceEksOnOutposts(_Compute): | ||
| _icon = "elastic-kubernetes-service-eks-on-outposts.png" | ||
|
|
||
|
|
||
| class ElasticKubernetesService(_Compute): | ||
| _icon = "elastic-kubernetes-service.png" | ||
|
|
||
|
|
||
| class ElasticVmwareService(_Compute): | ||
| _icon = "elastic-vmware-service.png" | ||
|
|
||
|
|
||
| class Fargate(_Compute): | ||
| _icon = "fargate.png" | ||
|
|
||
|
|
@@ -124,6 +200,10 @@ class Lambda(_Compute): | |
| _icon = "lambda.png" | ||
|
|
||
|
|
||
| class LightsailForResearch(_Compute): | ||
| _icon = "lightsail-for-research.png" | ||
|
|
||
|
|
||
| class Lightsail(_Compute): | ||
| _icon = "lightsail.png" | ||
|
|
||
|
|
@@ -132,14 +212,46 @@ class LocalZones(_Compute): | |
| _icon = "local-zones.png" | ||
|
|
||
|
|
||
| class NitroEnclaves(_Compute): | ||
| _icon = "nitro-enclaves.png" | ||
|
|
||
|
|
||
| class OutpostsFamily(_Compute): | ||
| _icon = "outposts-family.png" | ||
|
|
||
|
|
||
| class OutpostsRack(_Compute): | ||
| _icon = "outposts-rack.png" | ||
|
|
||
|
|
||
| class OutpostsServers(_Compute): | ||
| _icon = "outposts-servers.png" | ||
|
|
||
|
|
||
| class Outposts(_Compute): | ||
| _icon = "outposts.png" | ||
|
|
||
|
|
||
| class ParallelCluster(_Compute): | ||
| _icon = "parallel-cluster.png" | ||
|
|
||
|
|
||
| class ParallelComputingService(_Compute): | ||
| _icon = "parallel-computing-service.png" | ||
|
|
||
|
|
||
| class RedHatOpenshiftServiceOnAWS(_Compute): | ||
| _icon = "red-hat-openshift-service-on-aws.png" | ||
|
|
||
|
|
||
| class ServerlessApplicationRepository(_Compute): | ||
| _icon = "serverless-application-repository.png" | ||
|
|
||
|
|
||
| class SimspaceWeaver(_Compute): | ||
| _icon = "simspace-weaver.png" | ||
|
|
||
|
|
||
| class ThinkboxDeadline(_Compute): | ||
| _icon = "thinkbox-deadline.png" | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,10 @@ class AuroraAmazonRDSInstanceAlternate(_Database): | |
| _icon = "aurora-amazon-rds-instance-alternate.png" | ||
|
|
||
|
|
||
| class AuroraAmazonRDSInstanceAternate(_Database): | ||
| _icon = "aurora-amazon-rds-instance-aternate.png" | ||
|
|
||
|
Comment on lines
+19
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| class AuroraAmazonRDSInstance(_Database): | ||
| _icon = "aurora-amazon-rds-instance.png" | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EcsAnywhere,EksAnywhere, andEksDistrouse abbreviated prefixes (Ecs,Eks) while every other ECS/EKS sub-resource in this module follows the full-name convention (ElasticContainerService*,ElasticKubernetesService*). This is inconsistent with, e.g.,ElasticKubernetesServiceEksOnOutpostsadded in the same PR. Users discovering the API via autocomplete may not find these classes, and the mixed convention makes the module harder to reason about.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!