Skip to content

OCPBUGS-90077: Fix infinite reboot on SSH exit command status #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jul 9, 2026
Merged

OCPBUGS-90077: Fix infinite reboot on SSH exit command status #4284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/windows/windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,9 @@ func (vm *windows) Run(cmd string, psCmd bool) (string, error) {
// RebootAndReinitialize restarts the Windows instance and re-initializes the SSH connection for further configuration
func (vm *windows) RebootAndReinitialize(ctx context.Context) error {
vm.log.Info("rebooting instance")
if _, err := vm.Run("Restart-Computer -Force", true); err != nil {
// SSH connection may terminate during reboot before returning exit status - this is expected
// The real validation is waitUntilUnreachable() and reinitialize(), so we only fail on unexpected errors
if _, err := vm.Run("Restart-Computer -Force", true); err != nil && !strings.Contains(err.Error(), cmdExitNoStatus) {
return fmt.Errorf("error rebooting the Windows VM: %w", err)
}
// Wait for instance to be unreachable via SSH, implies reboot is underway
Expand Down