Skip to content

Enable cluster-update-console-plugin image promotion for 5.0 #80758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhadvig wants to merge 1 commit into from
Closed

Enable cluster-update-console-plugin image promotion for 5.0 #80758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ft/cluster-update-console-plugin/openshift-cluster-update-console-plugin-release-5.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ images:
to: cluster-update-console-plugin
promotion:
to:
- disabled: true
name: "5.0"
- name: "5.0"
namespace: ocp
Comment on lines 7 to 10

@coderabbitai coderabbitai Bot Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check for main/master config that would conflict with this release-5.0 promotion

BASE_DIR="ci-operator/config/openshift/cluster-update-console-plugin"

# Check if main or master config exists
echo "=== Checking for main/master configs ==="
fd -t f 'openshift-cluster-update-console-plugin-(main|master)\.yaml$' "$BASE_DIR"

# If found, check their promotion targets
for config in "$BASE_DIR"/openshift-cluster-update-console-plugin-{main,master}.yaml; do
  if [[ -f "$config" ]]; then
    echo "=== Checking promotion in $(basename "$config") ==="
    # Extract promotion.to[] entries
    python3 -c "
import yaml, sys
with open('$config') as f:
    data = yaml.safe_load(f)
promo = data.get('promotion', {}).get('to', [])
for entry in promo:
    name = entry.get('name', '')
    ns = entry.get('namespace', 'ocp')
    disabled = entry.get('disabled', False)
    print(f'{ns}/{name} (disabled={disabled})')
"
  fi
done

# Run the promotion guard validator
echo "=== Running promotion guard validator ==="
python3 hack/validate-main-promotion-guard.py

Repository: openshift/release

Length of output: 1582

Revert promotion change; it violates the promotion guard validator.

The release-5.0 config cannot promote to ocp/5.0 because the main config already does. The promotion guard validator explicitly forbids this pattern:

ERROR: Main/master must promote to current release only; release-5.0 configs must have promotion disabled.
      main/master -> ocp/5.0, ocp-private/5.0-priv. release-5.0 / openshift-5.0 -> promotion disabled.

The openshift-cluster-update-console-plugin-main.yaml config already promotes to ocp/5.0 with disabled=False. Removing disabled: true from the release-5.0 config violates the rule that only main/master should promote to the current release.

If additional promotion configuration is needed to fix the image availability issue, it should be made in the main config, not in the release branch config.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/cluster-update-console-plugin/openshift-cluster-update-console-plugin-release-5.0.yaml`
around lines 7 - 10, The promotion configuration added to the release-5.0 config
violates the promotion guard validator rule that only main/master configs should
promote to the current release. Remove the promotion block (the lines promoting
to ocp/5.0) from openshift-cluster-update-console-plugin-release-5.0.yaml, as
the openshift-cluster-update-console-plugin-main.yaml config already handles
promotions to ocp/5.0 with disabled=False. If additional promotion configuration
is needed to resolve image availability issues, make those changes in the main
config file instead of the release branch config.

releases:
latest:
Expand Down