Skip to content

OCPBUGS-87001: Update source of CAPI ImageVolumeAlreadyPresent events#31286

Open
mdbooth wants to merge 1 commit into
openshift:mainfrom
mdbooth:fix-capi-installer-event-match
Open

OCPBUGS-87001: Update source of CAPI ImageVolumeAlreadyPresent events#31286
mdbooth wants to merge 1 commit into
openshift:mainfrom
mdbooth:fix-capi-installer-event-match

Conversation

@mdbooth

@mdbooth mdbooth commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

openshift/cluster-capi-operator#576 changes the name of the deployment which produces these events, which breaks the existing match.

Also update the comment to note that the upstream fix merged and will be in 1.37.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced image volume event detection to recognize newer installer naming patterns in test environments.

openshift/cluster-capi-operator#576 changes the
name of the deployment which produces these events, which breaks the
existing match.

Also update the comment to note that the upstream fix merged and will be
in 1.37.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@mdbooth: This pull request references Jira Issue OCPBUGS-87001, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d6d754c9-a940-44c2-b53a-b9c5705fd00d

📥 Commits

Reviewing files that changed from the base of the PR and between af43b92 and 18b78c3.

📒 Files selected for processing (1)
  • pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

Walkthrough

The pull request updates a pathological-event matcher in the test infrastructure library to recognize duplicate image-volume pulled events from both capi-operator and capi-installer pod names. The pod locator regex is expanded from capi-operator-* to capi-(operator|installer)-*, and documentation comments are revised to reflect this broader pattern coverage.

Changes

CAPI Pod Locator Pattern Expansion

Layer / File(s) Summary
ImageVolumeAlreadyPresent matcher regex update
pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go
The LocatorPodKey regex in the ImageVolumeAlreadyPresent matcher is changed from matching only capi-operator-* to matching `capi-(operator

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the ImageVolumeAlreadyPresent event matcher to handle both capi-operator and capi-installer naming patterns.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies monitoring event matcher code in duplicated_event_patterns.go, not Ginkgo test code. No Ginkgo test names (It(), Describe(), Context(), etc.) are present in the modified files.
Test Structure And Quality ✅ Passed PR does not contain Ginkgo test code. Test files added use standard Go testing with table-driven tests, not Ginkgo framework, making the custom check inapplicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are limited to updating a pathological event matcher pattern in a library file, which is outside the scope of the MicroShift compatibility check.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The changes only modify an existing pathological event matcher in a library file to support additional pod naming patterns.
Topology-Aware Scheduling Compatibility ✅ Passed Changes are to a test library file (event matcher regexes), not deployment manifests or operator code. No scheduling constraints, affinity rules, topology spreads, or topology assumptions are intro...
Ote Binary Stdout Contract ✅ Passed The modified file is a library module (pathologicaleventlibrary) containing no process-level code or stdout writes. Changes are limited to comment updates and regex pattern modifications for event...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR does not add new Ginkgo e2e tests; it modifies a library file (duplicated_event_patterns.go) that defines event matchers. The custom check applies only to new Ginkgo test code.
No-Weak-Crypto ✅ Passed The PR modifies a test event matching library file with regex patterns only. No cryptographic operations, weak ciphers, or non-constant-time comparisons are present in the changes.
Container-Privileges ✅ Passed This PR modifies a Go test monitoring library file (duplicated_event_patterns.go) to update regex patterns for matching CAPI test events. It contains no Kubernetes manifests, container specificatio...
No-Sensitive-Data-In-Logs ✅ Passed PR only updates event matcher regex patterns and comments; no new logging statements or sensitive data exposure introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 11, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@damdo damdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@damdo

damdo commented Jun 11, 2026

Copy link
Copy Markdown
Member

/assign @neisw @miyadav

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2026
@miyadav

miyadav commented Jun 11, 2026

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, mdbooth, miyadav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2026
@mdbooth

mdbooth commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

This will be
/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@mdbooth: This PR has been marked as verified by CI.

Details

In response to this:

This will be
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mdbooth

mdbooth commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Infra flake
/test e2e-aws-ovn-fips

@mdbooth

mdbooth commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

@mdbooth

mdbooth commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

The e2e-aws-ovn-fips job seems to be permafailing since #31287 landed. Possible fix here: openshift-eng/openshift-tests-extension#70

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD bde16f5 and 2 for PR HEAD 18b78c3 in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7dda95d and 1 for PR HEAD 18b78c3 in total

@damdo

damdo commented Jun 12, 2026

Copy link
Copy Markdown
Member

/retest-required

@mdbooth

mdbooth commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-ovn-fips

3 similar comments
@mdbooth

mdbooth commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-ovn-fips

@mdbooth

mdbooth commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-ovn-fips

@mdbooth

mdbooth commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-ovn-fips

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips 18b78c3 link true /test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mdbooth

mdbooth commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-ovn-fips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants