[release-4.19] OCPBUGS-98330: remove resource limits from Agent CAPI provider#8981
Conversation
The Agent CAPI provider deployment had resource limits (cpu: 200m, memory: 100Mi) that were copy-pasted from the upstream cluster-api-provider-agent operator-sdk scaffold defaults when the deployment was first added to HyperShift (commit 4a4630f, 2021-12-30). These limits were never intentionally sized for the workload. All other platforms (AWS, KubeVirt, PowerVS, GCP, Azure) only set resource requests without limits. Removing the limits aligns the Agent platform with this established convention and prevents unnecessary CPU throttling and OOM kills. Ref: OCPBUGS-76977 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-78400 has been cloned as Jira Issue OCPBUGS-98330. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-98330, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/uncc @rtheis |
This is an automated cherry-pick of #7947
/assign openshift-cherrypick-robot
/cherrypick release-4.18 release-4.17