Skip to content

[release-4.19] OCPBUGS-98330: remove resource limits from Agent CAPI provider#8981

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-7947-to-release-4.19
Open

[release-4.19] OCPBUGS-98330: remove resource limits from Agent CAPI provider#8981
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-7947-to-release-4.19

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #7947

/assign openshift-cherrypick-robot

/cherrypick release-4.18 release-4.17

The Agent CAPI provider deployment had resource limits (cpu: 200m,
memory: 100Mi) that were copy-pasted from the upstream
cluster-api-provider-agent operator-sdk scaffold defaults when
the deployment was first added to HyperShift (commit 4a4630f,
2021-12-30). These limits were never intentionally sized for the
workload.

All other platforms (AWS, KubeVirt, PowerVS, GCP, Azure) only set
resource requests without limits. Removing the limits aligns the
Agent platform with this established convention and prevents
unnecessary CPU throttling and OOM kills.

Ref: OCPBUGS-76977

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b41a751a-1797-4e4c-83d7-d1139f89bb39

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from rtheis and sjenning July 10, 2026 09:07
@openshift-ci openshift-ci Bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Jul 10, 2026
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-78400 has been cloned as Jira Issue OCPBUGS-98330. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-98330: remove resource limits from Agent CAPI provider

Details

In response to this:

This is an automated cherry-pick of #7947

/assign openshift-cherrypick-robot

/cherrypick release-4.18 release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.19] OCPBUGS-78400: remove resource limits from Agent CAPI provider [release-4.19] OCPBUGS-98330: remove resource limits from Agent CAPI provider Jul 10, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-98330, which is invalid:

  • expected dependent Jira Issue OCPBUGS-78400 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #7947

/assign openshift-cherrypick-robot

/cherrypick release-4.18 release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 28cf1e2 link true /test e2e-aws
ci/prow/e2e-kubevirt-aws-ovn-reduced 28cf1e2 link true /test e2e-kubevirt-aws-ovn-reduced
ci/prow/e2e-aws-upgrade-hypershift-operator 28cf1e2 link true /test e2e-aws-upgrade-hypershift-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rtheis

rtheis commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

/uncc @rtheis

@openshift-ci openshift-ci Bot removed the request for review from rtheis July 12, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants