[release-4.22] OCPBUGS-98328: fix(kubevirt): use only first MachineInternalIP per family in EndpointSlice endpoints by openshift-cherrypick-robot · Pull Request #8979 · openshift/hypershift

openshift-cherrypick-robot · 2026-07-10T08:44:49Z

This is an automated cherry-pick of #8892

/assign dpateriya

…tSlice endpoints Since CAPK PR openshift#366 exposes all VMI interface IPs for dual-stack CSR approval, Machine.Status.Addresses includes ovn-k8s-mp0 management port IPs from the guest cluster's OVN overlay alongside the VM's routable pod network IP. The HCCO machine controller was putting all MachineInternalIP addresses into EndpointSlice Endpoint.Addresses, causing MetalLB/kube-proxy to round-robin traffic to non-routable IPs and producing ~50% connection timeouts on LoadBalancer services. The existing link-local filter (OCPBUGS-83711) does not catch these IPs because they are regular RFC1918 addresses (e.g. 10.8.x.2), not link-local. Use only the first MachineInternalIP per IP family, which is the VM's primary pod network IP on the management cluster. This matches the convention already used in e2e tests (firstMachineAddress). Signed-off-by: Divyam Pateriya <dpateriy@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

coderabbitai · 2026-07-10T08:44:56Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: da869f8c-986f-4333-b010-c081c2084426

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci-robot · 2026-07-10T08:46:02Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-95615 has been cloned as Jira Issue OCPBUGS-98328. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-98328: fix(kubevirt): use only first MachineInternalIP per family in EndpointSlice endpoints

Details

In response to this:

This is an automated cherry-pick of #8892

/assign dpateriya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-07-10T08:46:12Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-98328, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-95615 to target a version in 5.0.0, but it targets "5.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #8892

/assign dpateriya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2026-07-10T08:57:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.86%. Comparing base (370b2b2) to head (b6b29f6).

Additional details and impacted files

@@              Coverage Diff              @@
##           release-4.22    #8979   +/-   ##
=============================================
  Coverage         35.86%   35.86%           
=============================================
  Files               774      774           
  Lines             94736    94739    +3     
=============================================
+ Hits              33973    33976    +3     
  Misses            57982    57982           
  Partials           2781     2781

Files with missing lines	Coverage Δ
...usterconfigoperator/controllers/machine/machine.go	`67.64% <100.00%> (+0.48%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

openshift-ci · 2026-07-10T09:00:10Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bryan-cox · 2026-07-13T14:24:27Z

/jira refresh

openshift-ci-robot · 2026-07-13T14:24:32Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-98328, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-95615 to target a version in 5.0.0, but it targets "5.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bryan-cox · 2026-07-13T14:26:34Z

@dpateriya you'll need to clean these up to get the right bug label on this one - #8979 (comment)

dpateriya · 2026-07-13T16:05:54Z

/jira refresh

openshift-ci-robot · 2026-07-13T16:05:59Z

@dpateriya: This pull request references Jira Issue OCPBUGS-98328, which is invalid:

expected dependent Jira Issue OCPBUGS-95615 to target a version in 5.0.0, but it targets "5.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dpateriya · 2026-07-13T16:07:04Z

/jira refresh

openshift-ci-robot · 2026-07-13T16:07:08Z

@dpateriya: This pull request references Jira Issue OCPBUGS-98328, which is invalid:

expected the bug to target only the "4.22.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dpateriya · 2026-07-13T16:07:40Z

/jira refresh

openshift-ci-robot · 2026-07-13T16:07:46Z

@dpateriya: This pull request references Jira Issue OCPBUGS-98328, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-95615 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-95615 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dpateriya · 2026-07-13T16:08:18Z

@dpateriya you'll need to clean these up to get the right bug label on this one - #8979 (comment)

done

bryan-cox · 2026-07-13T20:55:34Z

/approve

openshift-ci · 2026-07-13T20:55:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-cherrypick-robot assigned dpateriya Jul 10, 2026

openshift-cherrypick-robot mentioned this pull request Jul 10, 2026

OCPBUGS-95615: fix(kubevirt): use only first MachineInternalIP per family in EndpointSlice endpoints #8892

Merged

4 tasks

openshift-ci Bot added do-not-merge/needs-area area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release labels Jul 10, 2026

openshift-ci Bot requested review from bryan-cox and cblecker July 10, 2026 08:45

openshift-ci Bot removed the do-not-merge/needs-area label Jul 10, 2026

openshift-ci Bot changed the title ~~[release-4.22] OCPBUGS-95615: fix(kubevirt): use only first MachineInternalIP per family in EndpointSlice endpoints~~ [release-4.22] OCPBUGS-98328: fix(kubevirt): use only first MachineInternalIP per family in EndpointSlice endpoints Jul 10, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 13, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2026

Uh oh!

Conversation

openshift-cherrypick-robot commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026

Review skipped

Uh oh!

openshift-ci-robot commented Jul 10, 2026

Uh oh!

openshift-ci-robot commented Jul 10, 2026

Uh oh!

codecov Bot commented Jul 10, 2026

Codecov Report

Uh oh!

openshift-ci Bot commented Jul 10, 2026

Uh oh!

bryan-cox commented Jul 13, 2026

Uh oh!

openshift-ci-robot commented Jul 13, 2026

Uh oh!

bryan-cox commented Jul 13, 2026

Uh oh!

dpateriya commented Jul 13, 2026

Uh oh!

openshift-ci-robot commented Jul 13, 2026

Uh oh!

dpateriya commented Jul 13, 2026

Uh oh!

openshift-ci-robot commented Jul 13, 2026

Uh oh!

dpateriya commented Jul 13, 2026

Uh oh!

openshift-ci-robot commented Jul 13, 2026

Uh oh!

dpateriya commented Jul 13, 2026

Uh oh!

bryan-cox commented Jul 13, 2026

Uh oh!

openshift-ci Bot commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants