Boilerplate: Update to 8fb7c801f68dc7e06e8d2ae138c2a98f0b234b56#322
Open
iamkirkbater wants to merge 1 commit into
Open
Conversation
Conventions: - openshift/golang-osd-operator: Update --- openshift/boilerplate@5c9b148...8fb7c80 commit: 8fb7c801f68dc7e06e8d2ae138c2a98f0b234b56 author: Josh Branham Remove user no longer in the org commit: adf5de77e6238d9697351b1030ec7f4c3e793bac author: Mitali Bhalla ROSA-745: MintMaker gomod batch + automerge via boilerplate renovate (#748) Enable grouped gomod manager in shared renovate.json with Mon-Fri 02:00-04:59 UTC batch window; pre-label lgtm/approved on safe patch/minor/digest updates; major gomod and Tekton updates open for manual review. Add lgtm/approved and Mon 03:00 UTC schedule to Dependabot docker template. Co-authored-by: Cursor <cursoragent@cursor.com> commit: fb6795dfd897e2b42b7d3b9646228812b57d98c8 author: Kirk Bater remove iamkirkbater from team leads alias commit: 1d09b759691974be7028624ad761eb25915d344c author: Christopher Collins Fix container-make leaving orphaned containers on interruption Add --rm to the detached container run so it self-removes when stopped. Add an EXIT trap to stop the container on abnormal exit (Ctrl+C, terminal close, SIGTERM). Disarm the trap before normal cleanup so the happy path uses the existing explicit rm -f without a redundant stop. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> commit: e63f1e4045c75dec240c472fa10d34c6d17bb85e author: red-hat-konflux[bot] chore(deps): update registry.access.redhat.com/ubi8/ubi-minimal:latest docker digest to 30b786d Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> commit: 44a1272cb93ca85457f7179a5eb98b578e3ca6c5 author: red-hat-konflux[bot] chore(deps): update konflux references (#749) Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com> commit: 3909bdfa084fe68bff714f4d7e764860ada91018 author: MitaliBhalla Revert "Merge pull request #741 from MitaliBhalla/chore/renovate-gomod-automerge" This reverts commit b9feed9077bb86729e82a40dc46e9343da59a915, reversing changes made to 1628663baae4b9c1b7c55ed302a3d9e99376d8c6. commit: e5238f5ec6979b77e1853198f77fed08ba1713fc author: MitaliBhalla Revert "Merge pull request #746 from MitaliBhalla/chore/renovate-gomod-daily-batch" This reverts commit dd0c8513538cbc8e2c9df5ce3c2053740d733f34, reversing changes made to bbab1081503624f1e013b398e1cd2a0806b5d834. commit: 6ccbd825498f0c7c16c9860084c674ded4d2e1e2 author: MitaliBhalla Pilot: narrow gomod schedule to current UTC hour for testing Thu 06:00-06:59 UTC (~11:30 AM-12:30 PM IST) so MintMaker can run soon after merge. Production window 02:00-04:59 Mon-Fri in a follow-up. Co-authored-by: Cursor <cursoragent@cursor.com> commit: eff876184ca983751b866c3cad7d7827c72438da author: MitaliBhalla Use short Thursday UTC window for MintMaker pilot test Temporary schedule 06:00-07:59 UTC (Thu) for immediate validation; restore 02:00-04:59 Mon-Fri in a follow-up after pilot sign-off. Co-authored-by: Cursor <cursoragent@cursor.com> commit: d621c3a4fc0f200b400683ae744daa6c0296752d author: MitaliBhalla Batch MintMaker gomod updates on a UTC weekday schedule Group patch/minor gomod bumps into one PR per repo and open them only UTC 02:00-04:59 on weekdays. Keep lgtm/approved for tide automerge; merge gating relies on Prow required checks (DPP), not a GitHub Action. Co-authored-by: Cursor <cursoragent@cursor.com> commit: a8be62527cc4192704c8f0f61a7f82fe287da4c8 author: Andrew Pantuso feat: add generation logic to propagate CRDs to deploy_pko if present commit: c7cd213a17e83b13b310d112b2aff882cd1d4d93 author: Christopher Collins Revert golangci-lint bump to v2.7.2 The Go 1.26 upgrade is no longer needed — downstream operators are bumping down the kube components version instead. Revert golangci-lint from v2.12.2 back to v2.7.2. The Python 3.9 compatibility fix from PR #743 is intentionally preserved. This reverts the golangci-lint portion of 43f0781. Created with assistance from Claude 🤖 <claude@anthropic.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Christopher Collins <collins.christopher@gmail.com> commit: 43f0781250bdbc42890ac475f032296285c59594 author: Christopher Collins Bump golangci-lint to v2.12.2 for Go 1.26 support (#743) * Bump golangci-lint to v2.12.2 for Go 1.26 support Kubernetes v0.36.1 and controller-runtime v0.24.1 declare go 1.26.0 in their go.mod. The previous golangci-lint v2.7.2 was built with Go 1.25 and refuses to lint code targeting Go 1.26. Bumping to v2.12.2 (built with Go 1.26) unblocks operators upgrading to these dependencies. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix olm_pko_migration.py Python 3.9 compatibility The `str | None` union type syntax requires Python 3.10+. The boilerplate container image ships Python 3.9, causing the 08-pko-migration test to fail with TypeError. Use Optional[str] from typing instead. Created with assistance from Claude 🤖 <claude@anthropic.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Christopher Collins <collins.christopher@gmail.com> --------- Signed-off-by: Christopher Collins <collins.christopher@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> commit: 915fe611bee0958cec3c36f94294c533fcb7c740 author: devppratik Update pre-commit-yaml Add docs shorten the docs commit: f939c8d8d64f204a337372534003343078ab2341 author: MitaliBhalla Enable MintMaker automerge for gomod; pre-label Dependabot docker PRs Extend boilerplate renovate.json so gomod updates get the same automerge and lgtm/approved labels as Tekton. Keep Dependabot for /build docker; add lgtm and approved to the golang-osd-operator dependabot.yml template labels (with ok-to-test and area/dependency). Operators inherit renovate via extends; dependabot label changes apply on boilerplate-update. Co-authored-by: Cursor <cursoragent@cursor.com> commit: 0fd7c667224a7d6987d3af367801d790d815e495 author: red-hat-konflux[bot] chore(deps): update konflux references Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
Warning Review limit reached
More reviews will be available in 33 minutes and 38 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 43.28% 43.28%
=======================================
Files 11 11
Lines 834 834
=======================================
Hits 361 361
Misses 424 424
Partials 49 49 🚀 New features to boost your workflow:
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamkirkbater, typeid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Contributor
|
@iamkirkbater: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conventions:
openshift/boilerplate@5c9b148...8fb7c80
commit: 8fb7c801f68dc7e06e8d2ae138c2a98f0b234b56
author: Josh Branham
Remove user no longer in the org
commit: adf5de77e6238d9697351b1030ec7f4c3e793bac
author: Mitali Bhalla
ROSA-745: MintMaker gomod batch + automerge via boilerplate renovate (#748)
Enable grouped gomod manager in shared renovate.json with Mon-Fri 02:00-04:59
UTC batch window; pre-label lgtm/approved on safe patch/minor/digest updates;
major gomod and Tekton updates open for manual review. Add lgtm/approved and
Mon 03:00 UTC schedule to Dependabot docker template.
Co-authored-by: Cursor cursoragent@cursor.com
commit: fb6795dfd897e2b42b7d3b9646228812b57d98c8
author: Kirk Bater
remove iamkirkbater from team leads alias
commit: 1d09b759691974be7028624ad761eb25915d344c
author: Christopher Collins
Fix container-make leaving orphaned containers on interruption
Add --rm to the detached container run so it self-removes when stopped.
Add an EXIT trap to stop the container on abnormal exit (Ctrl+C, terminal
close, SIGTERM). Disarm the trap before normal cleanup so the happy path
uses the existing explicit rm -f without a redundant stop.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
commit: e63f1e4045c75dec240c472fa10d34c6d17bb85e
author: red-hat-konflux[bot]
chore(deps): update registry.access.redhat.com/ubi8/ubi-minimal:latest docker digest to 30b786d
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
commit: 44a1272cb93ca85457f7179a5eb98b578e3ca6c5
author: red-hat-konflux[bot]
chore(deps): update konflux references (#749)
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
commit: 3909bdfa084fe68bff714f4d7e764860ada91018
author: MitaliBhalla
Revert "Merge pull request #741 from MitaliBhalla/chore/renovate-gomod-automerge"
This reverts commit b9feed9077bb86729e82a40dc46e9343da59a915, reversing
changes made to 1628663baae4b9c1b7c55ed302a3d9e99376d8c6.
commit: e5238f5ec6979b77e1853198f77fed08ba1713fc
author: MitaliBhalla
Revert "Merge pull request #746 from MitaliBhalla/chore/renovate-gomod-daily-batch"
This reverts commit dd0c8513538cbc8e2c9df5ce3c2053740d733f34, reversing
changes made to bbab1081503624f1e013b398e1cd2a0806b5d834.
commit: 6ccbd825498f0c7c16c9860084c674ded4d2e1e2
author: MitaliBhalla
Pilot: narrow gomod schedule to current UTC hour for testing
Thu 06:00-06:59 UTC (~11:30 AM-12:30 PM IST) so MintMaker can run soon after
merge. Production window 02:00-04:59 Mon-Fri in a follow-up.
Co-authored-by: Cursor cursoragent@cursor.com
commit: eff876184ca983751b866c3cad7d7827c72438da
author: MitaliBhalla
Use short Thursday UTC window for MintMaker pilot test
Temporary schedule 06:00-07:59 UTC (Thu) for immediate validation; restore
02:00-04:59 Mon-Fri in a follow-up after pilot sign-off.
Co-authored-by: Cursor cursoragent@cursor.com
commit: d621c3a4fc0f200b400683ae744daa6c0296752d
author: MitaliBhalla
Batch MintMaker gomod updates on a UTC weekday schedule
Group patch/minor gomod bumps into one PR per repo and open them only
UTC 02:00-04:59 on weekdays. Keep lgtm/approved for tide automerge;
merge gating relies on Prow required checks (DPP), not a GitHub Action.
Co-authored-by: Cursor cursoragent@cursor.com
commit: a8be62527cc4192704c8f0f61a7f82fe287da4c8
author: Andrew Pantuso
feat: add generation logic to propagate CRDs to deploy_pko if present
commit: c7cd213a17e83b13b310d112b2aff882cd1d4d93
author: Christopher Collins
Revert golangci-lint bump to v2.7.2
The Go 1.26 upgrade is no longer needed — downstream operators are
bumping down the kube components version instead. Revert golangci-lint
from v2.12.2 back to v2.7.2. The Python 3.9 compatibility fix from
PR #743 is intentionally preserved.
This reverts the golangci-lint portion of 43f0781.
Created with assistance from Claude 🤖 claude@anthropic.com
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Signed-off-by: Christopher Collins collins.christopher@gmail.com
commit: 43f0781250bdbc42890ac475f032296285c59594
author: Christopher Collins
Bump golangci-lint to v2.12.2 for Go 1.26 support (#743)
Kubernetes v0.36.1 and controller-runtime v0.24.1 declare go 1.26.0
in their go.mod. The previous golangci-lint v2.7.2 was built with
Go 1.25 and refuses to lint code targeting Go 1.26. Bumping to
v2.12.2 (built with Go 1.26) unblocks operators upgrading to these
dependencies.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
The
str | Noneunion type syntax requires Python 3.10+. Theboilerplate container image ships Python 3.9, causing the
08-pko-migration test to fail with TypeError. Use Optional[str]
from typing instead.
Created with assistance from Claude 🤖 claude@anthropic.com
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Signed-off-by: Christopher Collins collins.christopher@gmail.com
Signed-off-by: Christopher Collins collins.christopher@gmail.com
Co-authored-by: Claude Opus 4.6 (1M context) noreply@anthropic.com
commit: 915fe611bee0958cec3c36f94294c533fcb7c740
author: devppratik
Update pre-commit-yaml
Add docs
shorten the docs
commit: f939c8d8d64f204a337372534003343078ab2341
author: MitaliBhalla
Enable MintMaker automerge for gomod; pre-label Dependabot docker PRs
Extend boilerplate renovate.json so gomod updates get the same automerge
and lgtm/approved labels as Tekton. Keep Dependabot for /build docker;
add lgtm and approved to the golang-osd-operator dependabot.yml template
labels (with ok-to-test and area/dependency). Operators inherit renovate
via extends; dependabot label changes apply on boilerplate-update.
Co-authored-by: Cursor cursoragent@cursor.com
commit: 0fd7c667224a7d6987d3af367801d790d815e495
author: red-hat-konflux[bot]
chore(deps): update konflux references
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>