Skip to content

NE-2790: Update CoreDNS to v1.14.4 and Kubernetes 1.35#195

Draft
aswinsuryan wants to merge 1 commit into
openshift:mainfrom
aswinsuryan:NE-2790-update-coredns-1.14.4-k8s-0.35
Draft

NE-2790: Update CoreDNS to v1.14.4 and Kubernetes 1.35#195
aswinsuryan wants to merge 1 commit into
openshift:mainfrom
aswinsuryan:NE-2790-update-coredns-1.14.4-k8s-0.35

Conversation

@aswinsuryan

@aswinsuryan aswinsuryan commented Jul 8, 2026

Copy link
Copy Markdown

1. Why is this pull request needed and what does it do?

  • Update CoreDNS version from 1.13.1 to 1.14.4
  • Update Kubernetes dependencies from v0.34.1 to v0.35.4:
  • k8s.io/api
  • k8s.io/apimachinery
  • k8s.io/client-go
  • Update vendor directory with new dependencies

2. Which issues (if any) are related?

https://redhat.atlassian.net/browse/NE-2790

3. Which documentation changes (if any) need to be made?

4. Does this introduce a backward incompatible change or deprecation?

Summary by CodeRabbit

  • Chores
    • Updated the core version to 1.14.4.
    • Refreshed several Go dependencies, including Kubernetes-related packages and YAML/CLI utilities, to newer versions.
    • Removed a couple of unused test-only dependencies.

- Update CoreDNS version from 1.13.1 to 1.14.4
- Update Kubernetes dependencies from v0.34.1 to v0.35.4:
  - k8s.io/api
  - k8s.io/apimachinery
  - k8s.io/client-go
- Update vendor directory with new dependencies

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown

@aswinsuryan: This pull request references NE-2790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

1. Why is this pull request needed and what does it do?

  • Update CoreDNS version from 1.13.1 to 1.14.4
  • Update Kubernetes dependencies from v0.34.1 to v0.35.4:
  • k8s.io/api
  • k8s.io/apimachinery
  • k8s.io/client-go
  • Update vendor directory with new dependencies

2. Which issues (if any) are related?

https://redhat.atlassian.net/browse/NE-2790

3. Which documentation changes (if any) need to be made?

4. Does this introduce a backward incompatible change or deprecation?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign candita for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Walkthrough

This PR updates the exported CoreVersion constant from "1.13.1" to "1.14.4" in coremain/version.go, and bumps several Go module dependencies in go.mod, including Kubernetes packages (v0.34.1 to v0.35.4) and various indirect dependencies.

Changes

Version and Dependency Updates

Layer / File(s) Summary
Core version bump
coremain/version.go
CoreVersion constant updated from "1.13.1" to "1.14.4".
Dependency version bumps
go.mod
Kubernetes packages (k8s.io/api, k8s.io/apimachinery, k8s.io/client-go) upgraded from v0.34.1 to v0.35.4; indirect dependencies (github.com/Masterminds/semver/v3, github.com/spf13/pflag, go.yaml.in/yaml/v2, gopkg.in/evanphx/json-patch.v4, k8s.io/kube-openapi, k8s.io/utils, sigs.k8s.io/json) updated; github.com/onsi/ginkgo/v2 and github.com/onsi/gomega removed from indirect requires.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No *_test.go files changed in the PR, so there are no Ginkgo titles to check for stability.
Test Structure And Quality ✅ Passed No Ginkgo or other test files are changed; the PR only updates version/dependencies/vendor content, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed No new non-vendor Ginkgo/e2e tests were added; the diff only changes version.go, go.mod, and go.sum with no MicroShift-sensitive test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Diff touches version/dependency/vendor files only; no _test.go files changed, so no new Ginkgo e2e tests to vet for SNO.
Topology-Aware Scheduling Compatibility ✅ Passed Only version and dependency/vendor bumps changed; no manifests, controllers, or pod scheduling logic were modified.
Ote Binary Stdout Contract ✅ Passed No changed process-level code writes to stdout; print hits are pflag docs/examples, and touched init/setup paths only register schemes/config.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Diff is version/dependency/vendor-only; no new Ginkgo e2e tests or IPv4/external-network assumptions were added.
No-Weak-Crypto ✅ Passed Diff only updates version/deps; exact scan found no added MD5/SHA1/DES/RC4/ECB or unsafe secret-compare code.
Container-Privileges ✅ Passed PR only updates version/go.mod/go.sum/vendor; no container/K8s manifests or privilege settings were changed.
No-Sensitive-Data-In-Logs ✅ Passed New klog calls log plugin names, watcher types, and taint values only; no passwords, tokens, PII, or internal hostnames are exposed.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main changes: CoreDNS was updated to v1.14.4 and Kubernetes dependencies were bumped to 1.35-related versions.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aswinsuryan aswinsuryan marked this pull request as ready for review July 8, 2026 14:49
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2026
@openshift-ci openshift-ci Bot requested review from frobware and gcs278 July 8, 2026 14:50
@aswinsuryan aswinsuryan changed the title NE-2790: Update CoreDNS to v1.14.4 and Kubernetes to v0.35.4 NE-2790: Update CoreDNS to v1.14.4 and Kubernetes 1.35 Jul 8, 2026
@gcs278

gcs278 commented Jul 8, 2026

Copy link
Copy Markdown

/assign @bentito

@gcs278

gcs278 commented Jul 8, 2026

Copy link
Copy Markdown

/assign @gcs278

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown

@aswinsuryan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-serial-2of2 8827209 link true /test e2e-gcp-serial-2of2
ci/prow/unit 8827209 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gcs278

gcs278 commented Jul 9, 2026

Copy link
Copy Markdown

@aswinsuryan I think there is a misunderstanding - coredns is not a vendor bump, it's a full rebase. This is a fork of the coredns repo, so we need to a git rebase onto CoreDNS's 1.14.4 repo. Please follow #118 or #157 or #160 as examples.

I also started the /rebase AI skill here: #161, but never quite got it ironed out.

My only request (which btw slightly differs from the way @bentito did it in #157 ) is to keep the carry-patches after the merge commit, so that a script/AI tool can easily identify carry patches (otherwise, it's really tricky to find the difference between a rebased commit and a cherry-pick) like this:

image

Let me know if you have any questions.

@aswinsuryan aswinsuryan marked this pull request as draft July 9, 2026 17:25
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants