NE-2790: Update CoreDNS to v1.14.4 and Kubernetes 1.35#195
Conversation
- Update CoreDNS version from 1.13.1 to 1.14.4 - Update Kubernetes dependencies from v0.34.1 to v0.35.4: - k8s.io/api - k8s.io/apimachinery - k8s.io/client-go - Update vendor directory with new dependencies Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
@aswinsuryan: This pull request references NE-2790 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughThis PR updates the exported ChangesVersion and Dependency Updates
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/assign @bentito |
|
/assign @gcs278 |
|
@aswinsuryan: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@aswinsuryan I think there is a misunderstanding - coredns is not a vendor bump, it's a full rebase. This is a fork of the coredns repo, so we need to a git rebase onto CoreDNS's 1.14.4 repo. Please follow #118 or #157 or #160 as examples. I also started the My only request (which btw slightly differs from the way @bentito did it in #157 ) is to keep the carry-patches after the merge commit, so that a script/AI tool can easily identify carry patches (otherwise, it's really tricky to find the difference between a rebased commit and a cherry-pick) like this:
Let me know if you have any questions. |

1. Why is this pull request needed and what does it do?
2. Which issues (if any) are related?
https://redhat.atlassian.net/browse/NE-2790
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?
Summary by CodeRabbit