Skip to content

Set minimum version of 4.20 required to upgrade to 4.21#9494

Open
aksjadha wants to merge 1 commit into
openshift:masterfrom
aksjadha:auto-node-min-version-420
Open

Set minimum version of 4.20 required to upgrade to 4.21#9494
aksjadha wants to merge 1 commit into
openshift:masterfrom
aksjadha:auto-node-min-version-420

Conversation

@aksjadha

@aksjadha aksjadha commented May 20, 2026

Copy link
Copy Markdown

Fixes: Related to fix #OCPBUGS-83862 to be applied before upgrading to 4.21

This change introduces a gate to block 4.20 clusters from upgrading to 4.21 until the prerequisite patch for Auto Node Sizing has been applied.

Requirement: The necessary 4.20 patch openshift/machine-config-operator#5885 introduces a specific MachineConfig to enforce this disabled state for master and worker mcp. This is fixed in 4.20.25.

Goal: This PR ensures upgrade safety by confirming the presence of that MachineConfig before proceeding to 4.21.

@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 89ce9232-44cb-4748-9c03-a1ba58f95301

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from PratikMahajan and wking May 20, 2026 09:40
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2026
@openshift-ci

openshift-ci Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Hi @aksjadha. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aksjadha aksjadha force-pushed the auto-node-min-version-420 branch from 5177d09 to 32dd53a Compare June 15, 2026 07:42
@aksjadha aksjadha marked this pull request as ready for review June 15, 2026 07:45
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2026
@openshift-ci openshift-ci Bot requested a review from DavidHurta June 15, 2026 07:45
@ngopalak-redhat

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2026
@ngopalak-redhat

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2026
@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aksjadha, ngopalak-redhat
Once this PR has been reviewed and has the lgtm label, please assign pratikmahajan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@aksjadha: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aksjadha

aksjadha commented Jun 19, 2026

Copy link
Copy Markdown
Author

/assign @wking

@wking can you please review and approve PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants