Repository navigation
chore(deps): update module github.com/matttproud/golang_protobuf_extensions to v2 - #1033
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux-kflux-prd-rh03[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh03[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
=======================================
Coverage 46.65% 46.65%
=======================================
Files 46 46
Lines 7033 7033
=======================================
Hits 3281 3281
Misses 3414 3414
Partials 338 338 🚀 New features to boost your workflow:
|
a3927c1 to
a75967b
Compare
…nsions to v2 Signed-off-by: red-hat-konflux-kflux-prd-rh03 <206760901+red-hat-konflux-kflux-prd-rh03[bot]@users.noreply.github.com>
a75967b to
ee75a12
Compare
|
@red-hat-konflux-kflux-prd-rh03[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This looks like a downgrade, closing. Must be a mintmaker issue. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
v1.0.4→v2.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
matttproud/golang_protobuf_extensions (github.com/matttproud/golang_protobuf_extensions)
v2.0.0Compare Source
Summary: Modernization of this package to Go standards in 2022, mostly
through internal cleanups.
New Features: None
The last time this package was significantly modified was 2016, which predates
cmp, subtests, the modern Protocol Buffer implementation, and numerous Gopractices that emerged in the intervening years. The new release is tested
against Go 1.19, though I expect it would work with Go 1.13 just fine.
Finally, I declared bankruptcy on the vendored test fixtures and opted for
creating my own. This is due to the underlying implementation of the generated
code in conjunction with working with a moving target that is an external data
model representation.
Upgrade Notes: This is the aborted v1.0.3 release repackaged as a new
major version 2. To use this, you will need to do or check the following:
The Protocol Buffer messages you provide to this API are from the
google.golang.org/protobufmodule. Take special care to audit anygenerated or checked-in Protocol Buffer message file assets. They may need
to be regenerated.
Your code should presumably use the
google.golang.org/protobufmodule forProtocol Buffers.
This is a new major version of the module, so you will need to transition
from module
github.com/matttproud/golang_protobuf_extensionstogithub.com/matttproud/golang_protobuf_extensions/v2.Configuration
📅 Schedule: (in timezone UTC)
* 2-4 * * 1-5)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.