Skip to content

CORS-4529: Azure IL6 Secret Cloud support#2919

Open
jhixson74 wants to merge 1 commit into
openshift:masterfrom
jhixson74:master-azure-il6
Open

CORS-4529: Azure IL6 Secret Cloud support#2919
jhixson74 wants to merge 1 commit into
openshift:masterfrom
jhixson74:master-azure-il6

Conversation

@jhixson74

Copy link
Copy Markdown
Member

Add Azure Government Secret IL6 Cloud as a valid Azure cloud environment

- Add Azure Government Secret IL6 Cloud as a valid Azure cloud
environment.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Hello @jhixson74! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown

@jhixson74: This pull request references CORS-4259 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.0." or "openshift-5.0.", but it targets "4.21.0" instead.

Details

In response to this:

Add Azure Government Secret IL6 Cloud as a valid Azure cloud environment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2026
@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This change introduces a new Azure cloud environment value, AzureUSSecCloud, to the AzureCloudEnvironment type in the API definition, including its kubebuilder enum validation annotation and constant declaration. The change is propagated across all generated CRD manifests for Infrastructure and ControllerConfig resources (Default, OKD, Hypershift, and SelfManagedHA variants across all upgrade channels), extending the cloudName enum field under platformStatus.azure in each schema to accept the new value.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or changed; the only Go edit is an enum/type update, and no changed file is a test/spec file.
Test Structure And Quality ✅ Passed No Ginkgo test files changed; the PR only updates Azure enum constants and CRD manifests.
Microshift Test Compatibility ✅ Passed PR only adds AzureUSSecCloud enum/CRD values; no new Ginkgo tests or MicroShift-unsupported APIs/resources were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit only updates API/CRD manifests for Azure IL6 cloud; no Ginkgo/e2e test files or SNO-assumption tests were added.
Topology-Aware Scheduling Compatibility ✅ Passed Diff only adds AzureUSSecCloud to Azure cloud-environment enums/CRDs; no scheduling, affinity, toleration, or topology logic changed.
Ote Binary Stdout Contract ✅ Passed Only enum/CRD schema changes were found; no main/init/suite code or stdout logging was added in the touched Go file.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds AzureUSSecCloud enum values in types and generated CRDs; no new Ginkgo tests or network-dependent code paths were added.
No-Weak-Crypto ✅ Passed PASS: The diff only adds the AzureUSSecCloud enum/CRD value; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret-comparison code appears.
Container-Privileges ✅ Passed Touched files only add AzureUSSecCloud enum values; no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation settings were present.
No-Sensitive-Data-In-Logs ✅ Passed Diff only adds AzureUSSecCloud enum/schema values; no log statements or sensitive-data exposure was introduced.
Title check ✅ Passed The title clearly matches the change: adding Azure IL6 Secret Cloud support as a valid Azure cloud environment.
Description check ✅ Passed The description directly describes the implemented change to add Azure Government Secret IL6 Cloud as a valid Azure cloud environment.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jhixson74 jhixson74 changed the title CORS-4259: Azure IL6 Secret Cloud support CORS-4529: Azure IL6 Secret Cloud support Jul 8, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown

@jhixson74: This pull request references CORS-4529 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Add Azure Government Secret IL6 Cloud as a valid Azure cloud environment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhixson74

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown

@jhixson74: This pull request references CORS-4529 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sadasu

sadasu commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-techpreview
/test minor-e2e-upgrade-minor

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadasu
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhixson74

Copy link
Copy Markdown
Member Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 57814bd link true /test e2e-aws-ovn
ci/prow/minor-e2e-upgrade-minor 57814bd link true /test minor-e2e-upgrade-minor
ci/prow/e2e-azure 57814bd link true /test e2e-azure
ci/prow/e2e-aws-ovn-techpreview 57814bd link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants