OCPBUGS-90053: add new serviceAccountToken fs type

[atiratree]

then a followup is needed to update the psalabelsyncer in https://github.com/openshift/cluster-policy-controller/

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @atiratree! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@atiratree: This pull request references Jira Issue OCPBUGS-90053, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0dccacb0-df2d-4a59-a460-95b8bf36c599

📥 Commits

Reviewing files that changed from the base of the PR and between c74451d and fe59537.

📒 Files selected for processing (1)

• security/v1/types.go

---

📝 Walkthrough

Walkthrough

A single new exported constant, FSTypeServiceAccountToken, with value "serviceAccountToken" is added to the FSType variable block in security/v1/types.go. This extends the enumeration of recognized volume filesystem type identifiers used in the security API.

🚥 Pre-merge checks | ✅ 12 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	Ginkgo test code in tests/generator.go has assertions without meaningful failure messages (e.g., lines 107, 110, 126, 174, 253, 255, 304, 306), violating the requirement for diagnostic clarity.	Add meaningful failure messages to all assertions lacking them, such as: Expect(err).ToNot(HaveOccurred(), "failed to parse initial data") instead of bare Expect(err).ToNot(HaveOccurred()).
Microshift Test Compatibility	⚠️ Warning	PR adds Ginkgo e2e tests for machine.openshift.io APIs (ControlPlaneMachineSet) that are unavailable on MicroShift, without [apigroup:machine.openshift.io] tags or [Skipped:MicroShift] labels for a...	Add [apigroup:machine.openshift.io] tags to generated test names, or add [Skipped:MicroShift] labels, or guard test suite generation with MicroShift detection logic.
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess whether any description content relates to the changeset.	Add a pull request description explaining the purpose of the new serviceAccountToken fs type and any relevant context from OCPBUGS-90053.

✅ Passed checks (12 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a new serviceAccountToken filesystem type constant to the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test names in the PR are stable and deterministic with no dynamic content like UUIDs, timestamps, pod names, node names, IPs, or random suffixes.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR adds a single constant FSTypeServiceAccountToken to security/v1/types.go. No new Ginkgo e2e tests are added in this PR, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only adds a constant FSTypeServiceAccountToken to security/v1/types.go, which is an API type definition file with no deployment manifests, operator code, or controllers. No scheduling constraint...
Ote Binary Stdout Contract	✅ Passed	File is a types definition file with no process-level code, no functions, and no stdout-writing packages. The change only adds a constant definition which poses no risk to OTE binary stdout contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only adds a filesystem type constant (FSTypeServiceAccountToken) to security/v1/types.go. No Ginkgo e2e tests are added, so the check does not apply.
No-Weak-Crypto	✅ Passed	PR only adds a simple FSType constant "serviceAccountToken" with no cryptographic implementations, weak crypto algorithms, or secret comparisons.
Container-Privileges	✅ Passed	The PR only adds a filesystem type constant (FSTypeServiceAccountToken) to the types.go file and introduces no container privilege settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, al...
No-Sensitive-Data-In-Logs	✅ Passed	PR adds only a type constant definition to types.go with no logging code; the file contains no logging statements or output functions that could expose sensitive data.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@atiratree: This pull request references Jira Issue OCPBUGS-90053, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

then a followup is needed to update the psalabelsyncer in https://github.com/openshift/cluster-policy-controller/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

• The changed files don't match any pipeline_run_if_changed patterns
• All files match pipeline_skip_if_only_changed patterns
• No pipeline-controlled jobs are defined for the master branch

Use /test ? to see all available tests.

[atiratree]

/verified by ci
thx!

[openshift-ci-robot]

@atiratree: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci
thx!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@atiratree: Jira Issue Verification Checks: Jira Issue OCPBUGS-90053
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-90053 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

then a followup is needed to update the psalabelsyncer in https://github.com/openshift/cluster-policy-controller/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in release 5.0.0-0.nightly-2026-06-23-074322

[ingvagabund]

/cherry-pick release-4.22 release-4.21 release-4.20 release-4.19 release-4.18

[openshift-cherrypick-robot]

@ingvagabund: new pull request created: #2922

Details

In response to this:

/cherry-pick release-4.22 release-4.21 release-4.20 release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.