AGENT-1493: Promote NoRegistryClusterInstall Feature to Default

[sadasu]

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

[openshift-ci-robot]

@sadasu: This pull request references AGENT-1394 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target only the "5.0.0" version, but multiple target versions were set.

Details

In response to this:

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7b301951-10a8-4ff1-bc5f-bea3c85268fd

📥 Commits

Reviewing files that changed from the base of the PR and between e5c1c9a and 230642e.

⛔ Files ignored due to path filters (6)

• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_internalreleaseimages-SelfManagedHA.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1alpha1/zz_generated.crd-manifests/0000_80_machine-config_01_internalreleaseimages-SelfManagedHA.crd.yaml is excluded by !**/zz_generated.crd-manifests/*

📒 Files selected for processing (2)

• features.md
• features/features.go

✅ Files skipped from review due to trivial changes (1)

• features.md

---

📝 Walkthrough

Walkthrough

This PR enables NoRegistryClusterInstall for Default and OKD profiles, updates its payload manifests and documentation, and adds MachineConfigNode CRDs for SelfManagedHA Default and OKD with comprehensive spec, status, validation, versioning, release-image, and pinned-image schemas. Existing CRD annotations are also removed from related manifests.

Suggested reviewers: deads2k, JoelSpeed

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: promoting NoRegistryClusterInstall to the default-enabled state.
Description check	✅ Passed	The description is directly related to the changeset and accurately states the intended default support for the feature.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test titles were added or modified; the diff only changes feature-gate code and generated manifests.
Test Structure And Quality	✅ Passed	No _test.go files or Ginkgo/Gomega test code were changed in this PR; the diff only updates feature gates and generated CRD manifests.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only changes feature-gate code and CRD/manifests, with no It/Describe/Context/When additions.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: This PR only changes feature gates/CRDs/docs; no new Ginkgo e2e tests or SNO-sensitive test code was added.
Topology-Aware Scheduling Compatibility	✅ Passed	Touched files only adjust feature-gate defaults and CRD schemas; no pod scheduling fields (affinity, tolerations, replicas, nodeSelectors) were added.
Ote Binary Stdout Contract	✅ Passed	The only code change is a feature-gate initializer; no main/init/TestMain/suite setup or stdout-writing calls were added, and the rest are manifests/docs.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the touched files are feature-gate code and YAML manifests, and the changed paths contain no It/Describe/Context/When blocks.
No-Weak-Crypto	✅ Passed	Touched files contain no exact weak-crypto terms or secret-comparison APIs; changes are feature-gate/CRD manifest updates only.
Container-Privileges	✅ Passed	Changed files are CRDs/FeatureGates only, and no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation fields appear in them.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only changes feature-gate/CRD/docs manifests; no added log statements or PII/secret patterns were found in the diff.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @sadasu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sadasu: This pull request references AGENT-1493 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sadasu]

/jira refresh

[openshift-ci-robot]

@sadasu: This pull request references AGENT-1493 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[yuqi-zhang]

Looks like the IRI object itself is still v1alpha1 only: https://github.com/openshift/api/blob/master/machineconfiguration/v1alpha1/types_internalreleaseimage.go ?

We don't allow GA'ing with a alpha API. We would need to graduate the API to v1 first, before we graduate the dependent feature.

[andfasano]

Do we require a separate PR for that?

[sadasu]

@andfasano Yes, lets create a separate PR for that.

[andfasano]

Requires #2863

[pawanpinjarkar]

@sadasu the dependent PR #2880 is merged. Please rebase and fix the the conflicts.

[openshift-ci]

@sadasu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	230642e	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.