Skip to content

OCPBUGS-80958: NodeUID in status to detect replaced node with same name #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhperry wants to merge 1 commit into
base: master
Choose a base branch
from
+312 −3
Open

OCPBUGS-80958: NodeUID in status to detect replaced node with same name #2821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions openapi/generated_openapi/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 15 additions & 3 deletions openapi/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9257,7 +9257,7 @@
],
"properties": {
"installationPolicy": {
"description": "installationPolicy controls whether network observability is installed during cluster deployment. Valid values are \"InstallAndEnable\" and \"NoAction\". When set to \"InstallAndEnable\", ensure that network observability will be installed and enabled on the cluster. If already installed, no action taken, but if it gets uninstalled, it will install it again. When set to \"NoAction\", nothing will be done regarding Network observability.",
"description": "installationPolicy controls whether network observability is installed during cluster deployment. Valid values are \"InstallAndEnable\" and \"NoAction\". When set to \"InstallAndEnable\", ensure that network observability will be installed and enabled on the cluster. If already installed, no action taken, but if it gets uninstalled, it will install it again. When set to \"NoAction\", nothing will be done regarding Network observability. During the installation of NetworkObservability, the platform checks for any existing manual installations. If a successful installation using the OLMv0 or OLMv1 API is detected, it will be used. If the platform cannot determine how the current version was installed, or if the existing installation is incomplete, the installation process will stop.",
"type": "string"
}
}
Expand Down Expand Up @@ -32116,8 +32116,8 @@
"description": "CustomSecretRotation holds configuration for custom secret rotation behavior.",
"type": "object",
"properties": {
"rotationPollIntervalSeconds": {
"description": "rotationPollIntervalSeconds is the minimum time in seconds between secret rotation attempts. The driver skips provider calls if less than this interval has elapsed since the last successful rotation. Must be at least 1 second and no more than 31560000 seconds (~1 year). When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.",
"minimumRefreshAge": {
"description": "minimumRefreshAge is the minimum time in seconds between secret rotation attempts. Each time kubelet calls NodePublishVolume, the driver checks whether this interval has elapsed since the last successful provider call. If it has, the driver contacts the secret provider to fetch the latest secret values and updates the mounted volume. Setting this value below the kubelet syncFrequency (default: 1 minute) has no additional effect on the actual rotation cadence. Must be at least 1 second and no more than 31560000 seconds (~1 year). When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.",
"type": "integer",
"format": "int32"
}
Expand Down Expand Up @@ -33572,6 +33572,10 @@
"description": "endpointPublishingStrategy is used to publish the ingress controller endpoints to other networks, enable load balancer integrations, etc.\n\nIf unset, the default is based on infrastructure.config.openshift.io/cluster .status.platform:\n\n AWS: LoadBalancerService (with External scope)\n Azure: LoadBalancerService (with External scope)\n GCP: LoadBalancerService (with External scope)\n IBMCloud: LoadBalancerService (with External scope)\n AlibabaCloud: LoadBalancerService (with External scope)\n Libvirt: HostNetwork\n\nAny other platform types (including None) default to HostNetwork.\n\nendpointPublishingStrategy cannot be updated.",
"$ref": "#/definitions/com.github.openshift.api.operator.v1.EndpointPublishingStrategy"
},
"haproxyVersion": {
"description": "haproxyVersion specifies the HAProxy version to use for this IngressController.\n\nOpenShift 5.0 introduces HAProxy 3.2 as its default version and supports HAProxy 2.8 from OpenShift 4.22 for migration purposes. When an OpenShift release introduces a new default HAProxy version, that HAProxy version becomes available as a pinnable value in subsequent OpenShift releases, providing a smooth migration path for administrators who want to defer HAProxy upgrades.\n\nValid values for OpenShift 5.0: - Unset (default): Uses HAProxy 3.2 (the default for OpenShift 5.0) - \"3.2\": Explicitly pins HAProxy 3.2 for preservation during cluster\n upgrades to future OpenShift releases\n- \"2.8\": Uses HAProxy 2.8 from OpenShift 4.22 (migration support, will\n be dropped in the next OpenShift release)\n\nIf a specific HAProxy version is set and would become unsupported in a target cluster upgrade, a preflight check will block the cluster upgrade until this field is updated to unset or a supported version.",
"type": "string"
},
"httpCompression": {
"description": "httpCompression defines a policy for HTTP traffic compression. By default, there is no HTTP compression.",
"default": {},
Expand Down Expand Up @@ -33662,6 +33666,10 @@
"type": "string",
"default": ""
},
"effectiveHAProxyVersion": {
"description": "effectiveHAProxyVersion reports the HAProxy version currently in use by this IngressController. This reflects the resolved value of the spec.haproxyVersion field. When omitted, the effective value has not yet been resolved by the operator or the feature is not enabled for this cluster.\n\nExamples for OpenShift 5.0: - \"3.2\": Using HAProxy 3.2 - \"2.8\": Using HAProxy 2.8",
"type": "string"
},
"endpointPublishingStrategy": {
"description": "endpointPublishingStrategy is the actual strategy in use.",
"$ref": "#/definitions/com.github.openshift.api.operator.v1.EndpointPublishingStrategy"
Expand Down Expand Up @@ -35813,6 +35821,10 @@
"type": "string",
"default": ""
},
"nodeUID": {
Comment thread
bhperry marked this conversation as resolved.
"description": "nodeUID is the UID of the node. This field is used to detect that a node has been deleted and recreated with the same name. When the UID changes, it indicates the node is a new instance and the controller should treat this status entry as stale. When omitted, UID-based node replacement detection is not available for this entry.",
"type": "string"
},
"targetRevision": {
"description": "targetRevision is the generation of the deployment we're trying to apply. Can not be set on creation of a nodeStatus.",
"type": "integer",
Expand Down
10 changes: 10 additions & 0 deletions operator/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package v1
import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
)

// MyOperatorResource is an example operator configuration type
Expand Down Expand Up @@ -266,6 +267,15 @@ type NodeStatus struct {
// +required
NodeName string `json:"nodeName"`

// nodeUID is the UID of the node.
Comment thread
bhperry marked this conversation as resolved.
// This field is used to detect that a node has been deleted and recreated
// with the same name. When the UID changes, it indicates the node is a
// new instance and the controller should treat this status entry as stale.
// When omitted, UID-based node replacement detection is not available
// for this entry.
// +optional
NodeUID types.UID `json:"nodeUID,omitempty"`

// currentRevision is the generation of the most recently successful deployment.
// Can not be set on creation of a nodeStatus. Updates must only increase the value.
// +kubebuilder:validation:XValidation:rule="self >= oldSelf",message="must only increase"
Expand Down
9 changes: 9 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions ...generated.crd-manifests/0000_20_kube-apiserver_01_kubeapiservers-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions ...r/v1/zz_generated.crd-manifests/0000_20_kube-apiserver_01_kubeapiservers-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions ...rated.crd-manifests/0000_20_kube-apiserver_01_kubeapiservers-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_20_kube-apiserver_01_kubeapiservers-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions ...ated.crd-manifests/0000_20_kube-apiserver_01_kubeapiservers-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions ...enerated.crd-manifests/0000_25_kube-controller-manager_01_kubecontrollermanagers.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_25_kube-scheduler_01_kubeschedulers.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
9 changes: 9 additions & 0 deletions ...r/v1/zz_generated.featuregated-crd-manifests/etcds.operator.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,15 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated
with the same name. When the UID changes, it indicates the node is a
new instance and the controller should treat this status entry as stale.
When omitted, UID-based node replacement detection is not available
for this entry.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
Loading