Add release test ginkgo pipeline - #27576
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pramodbindal The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR replaces the prior Konflux Tekton “bundle e2e” pipeline with a new Ginkgo-oriented release-test pipeline definition under .konflux/release-tests-ginkgo/, including a reusable Task to run the release tests against an ephemeral Hypershift cluster.
Changes:
- Removes the legacy
.konflux/tekton/bundle-e2e-pipeline.yamlpipeline. - Adds a new reusable Tekton Task to fetch and run the release-tests-ginkgo suite.
- Adds a new Tekton Pipeline that provisions EAAS + cluster, installs the operator, runs multiple release-test suites, and verifies aggregate status.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .konflux/tekton/bundle-e2e-pipeline.yaml | Removes the old bundle E2E pipeline definition. |
| .konflux/release-tests-ginkgo/task-e2e-pipeline.yaml | Adds a Task to clone and execute release tests (Ginkgo-oriented). |
| .konflux/release-tests-ginkgo/release-test-pipeline.yaml | Adds the new end-to-end release test Pipeline (provision, install, run suites, final status check). |
Suppressed comments (4)
.konflux/release-tests-ginkgo/release-test-pipeline.yaml:134
- The extract-and-pick-version step writes the step result to
/tekton/steps/step-extract-and-pick-version/..., but the step name isextract-and-pick-version. This will prevent$(steps.extract-and-pick-version.results.version)from being populated, so cluster creation may receive an empty version.
# Write result for create-cluster step
mkdir -p /tekton/steps/step-extract-and-pick-version/results
echo -n "$VERSION" | tee /tekton/steps/step-extract-and-pick-version/results/version
.konflux/release-tests-ginkgo/release-test-pipeline.yaml:228
- The CatalogSource YAML sets
updateStrategy:andregistryPoll:to null and placesintervalat the wrong level. This likely makes the applied manifest invalid or ignored by OLM.intervalshould be nested underupdateStrategy.registryPoll.
updateStrategy:
registryPoll:
interval: 30m
.konflux/release-tests-ginkgo/release-test-pipeline.yaml:549
- This step runs under
#!/bin/shbut uses[[ ... ]], which is not POSIX and can fail if/bin/shis not bash. Use[ ... ](or switch the shebang to bash).
if [[ "$(params.aggregateStatus)" != "Succeeded" ]]; then
.konflux/release-tests-ginkgo/task-e2e-pipeline.yaml:138
- This script uses bash-specific options (
set +H/set -H). Without a bash shebang, Tekton may run it under/bin/sh, which can fail depending on the image's/bin/shimplementation. Add an explicit bash shebang at the top of the script block.
# Some of the tests fail on specific OCP versions
set +H
tags="$(params.TAGS),!(skip-$OCP_VERSION | to-do)"
set -H
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: GIT_RELEASE_TESTS_BRANCH | ||
| default: master |
| - description: Namespace where the the Operator bundle will be deployed. | ||
| name: NAMESPACE |
| - name: FAIL_ON_ERROR | ||
| default: "false" |
No description provided.