fix(common): propagate config to StatefulSets too - #26961
Closed
smahadik-27 wants to merge 1 commit into
Closed
Conversation
The AddConfiguration transformer only handled Deployments, so TektonConfig.spec.config.nodeSelector and tolerations were not propagated to StatefulSet workloads like tekton-results-postgres. This change extends AddConfiguration to also handle StatefulSets, ensuring that all workloads respect the global scheduling configuration. Fixes: SRVKP-13067 Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smahadik-27 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddConfigurationtransformer to handle StatefulSets in addition to DeploymentsTektonConfig.spec.config.nodeSelectorandtolerationsare propagated totekton-results-postgresStatefulSetProblem
After upgrading to OpenShift Pipelines 1.20.5, customers configuring scheduling settings in
TektonConfigCR found that:nodeSelector/tolerationstekton-results-postgres) did not receive these settingsThis caused the PostgreSQL pod to remain scheduled on worker nodes instead of the intended infra nodes.
Root Cause
The
AddConfigurationtransformer inpkg/reconciler/common/transformers.goonly handledDeploymentresources, ignoringStatefulSetresources.Fix
Extended
AddConfigurationto use a switch statement that handles bothDeploymentandStatefulSetkinds, ensuring all workloads respect the global scheduling configuration.Test plan
TestAddConfigurationStatefulSetFixes: SRVKP-13067