Renaming rosa-regional-platform-api references to rosa-hyperfleet-api - #117
Renaming rosa-regional-platform-api references to rosa-hyperfleet-api#117ravitri wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ravitri The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughThis PR performs a project-wide rename from rosa-regional-platform-api to rosa-hyperfleet-api, updating the Go module path, all internal import paths, binary names, container/build scripts, Kubernetes/ArgoCD/Helm deployment resources, and documentation references accordingly, plus removing the old rosa-regional-frontend Helm chart. ChangesRepository rename
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| project: default | ||
| source: | ||
| repoURL: https://github.com/cdoan1/rosa-regional-platform-api | ||
| repoURL: https://github.com/cdoan1/rosa-hyperfleet-api |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
ci/build-push-image.sh (1)
12-17: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winDefault
IMAGE_REPOstill referencesrosa-regional-platform-api.Header comment and image-push default were only partially renamed — the actual default value at Line 17 (and its comment at Line 12) still push to
quay.io/cdoan0/rosa-regional-platform-api, contradicting the rename described in the PR.🔧 Proposed fix
-# IMAGE_REPO - destination image (default: quay.io/cdoan0/rosa-regional-platform-api) +# IMAGE_REPO - destination image (default: quay.io/cdoan0/rosa-hyperfleet-api) ... -IMAGE_REPO="${IMAGE_REPO:-quay.io/cdoan0/rosa-regional-platform-api}" +IMAGE_REPO="${IMAGE_REPO:-quay.io/cdoan0/rosa-hyperfleet-api}"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci/build-push-image.sh` around lines 12 - 17, The build script still defaults IMAGE_REPO to the old rosa-regional-platform-api image, so update the IMAGE_REPO header comment and the IMAGE_REPO assignment in build-push-image.sh to the new repository name. Make sure the default value used by the push logic matches the rename throughout the script.Makefile (1)
3-24: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
IMAGE_REPO/CI_IMAGE_REPOstill reference the oldrosa-regional-platform-apiname.
BINARY_NAMEandREPO_URLwere renamed to hyperfleet, butIMAGE_REPO(Line 4) andCI_IMAGE_REPO(Line 22) still point atrosa-regional-platform-api/rosa-regional-platform-api-ci, leaving the image build/push targets and the CI lint container inconsistent with the rest of the rename.🔧 Proposed fix
-IMAGE_REPO ?= quay.io/openshift-online/rosa-regional-platform-api +IMAGE_REPO ?= quay.io/openshift-online/rosa-hyperfleet-api ... -CI_IMAGE_REPO ?= quay.io/openshift-online/rosa-regional-platform-api-ci +CI_IMAGE_REPO ?= quay.io/openshift-online/rosa-hyperfleet-api-ci🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Makefile` around lines 3 - 24, Update the remaining container image defaults in Makefile to match the hyperfleet rename: IMAGE_REPO and CI_IMAGE_REPO still point to the old rosa-regional-platform-api names. Change those defaults so the image build/push targets and the CI lint container use the same renamed repository as BINARY_NAME and REPO_URL, keeping the Makefile variables consistent.cmd/rosa-hyperfleet-api/main.go (1)
73-76: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winStale service name in startup log message.
The startup log still identifies the service as
rosa-regional-platform-api, even though this PR renames the module and binary torosa-hyperfleet-api. This is user/operator-visible (log aggregation, dashboards) and should be updated for consistency with the rename.🏷️ Proposed fix
- logger.Info("starting rosa-regional-platform-api", + logger.Info("starting rosa-hyperfleet-api", "log_level", logLevel, "log_format", logFormat, )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cmd/rosa-hyperfleet-api/main.go` around lines 73 - 76, The startup log message still uses the old service name, so update the string in main.go where logger.Info is called to match the renamed binary/module `rosa-hyperfleet-api`. Keep the rest of the log fields the same and ensure any other startup or service-identifying messages in the entrypoint use the new name for consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/Containerfile`:
- Line 1: The Containerfile currently defines no non-root runtime user, so the
image will run as root by default. Update the CI image definition to add an
explicit non-root USER instruction in the Containerfile, placing it
appropriately after any setup steps so the final image runs as a restricted user
instead of root.
In `@CLAUDE.md`:
- Around line 46-49: Update the generated guidance in CLAUDE.md so it matches
the current backend description: replace the stale DynamoDB persistence note
with PostgreSQL, keeping the rest of the module guidance unchanged. This is a
documentation-only sync fix for the generated copy, so adjust the persistence
line near the module overview to align with AGENTS.md and avoid conflicting
guidance.
In `@deployment/argocd/application-helm-hook.yaml`:
- Around line 4-11: The ArgoCD application manifests are still referencing the
old Helm chart path, so update the source path in both application definitions
to the frontend chart location. In `application-helm-hook` and `application`
under the ArgoCD manifests, change the `source.path` value from the backend
chart directory to `deployment/helm/rosa-hyperfleet-frontend` so ArgoCD can
locate the chart correctly.
In `@deployment/argocd/application.yaml`:
- Around line 4-11: The ArgoCD Application is pointing to a non-existent chart
path, so update the source path in the application spec to the actual Helm chart
directory used by this app. Locate the Application manifest under the
spec.source configuration and change the path from the old chart location to
deployment/helm/rosa-hyperfleet-frontend so ArgoCD can find and sync the chart
successfully.
In `@deployment/helm/rosa-hyperfleet-frontend/README.md`:
- Around line 27-28: The install command and ArgoCD source paths are pointing at
the wrong chart directory. Update the references in the README and the related
application manifests so they use the same chart folder as this component, not
the non-frontend path. Use the existing chart-specific symbols and paths in the
README, application.yaml, and application-helm-hook.yaml to ensure all installs
and syncs target the frontend chart consistently.
In `@deployment/helm/rosa-hyperfleet-frontend/values.yaml`:
- Line 16: The app.image.repository value still points to the old
rosa-regional-platform-api image, so update the repository reference to the
renamed rosa-hyperfleet-api in the Helm values and keep it consistent with the
image reference used by the API manifest. Check the app.image.repository setting
in values.yaml and the corresponding image repository field in
deployment/manifests/api.yaml so both point to the new repository name.
In `@deployment/manifests/api.yaml`:
- Around line 131-150: The container image reference is still using the old
repository name, so update the image value in the rosa-hyperfleet deployment
spec to point to the new rosa-hyperfleet image instead of the stale
quay.io/cdoan0/rosa-regional-platform-api:latest reference; make the same
repository rename in the corresponding frontend Helm values entry so the
deployment and chart stay consistent. Locate and fix the image fields under the
rosa-hyperfleet container configuration and the rosa-hyperfleet-frontend values
to remove the old repo name entirely.
In `@README.md`:
- Around line 403-407: The CI blurb in the README still refers to the old
“platform-api image” wording, which is inconsistent with the current branding.
Update the compatibility test description near the
rosa-regionality-compatibility-e2e section to use the current API name
consistently, keeping the rest of the trigger and configuration text unchanged.
---
Outside diff comments:
In `@ci/build-push-image.sh`:
- Around line 12-17: The build script still defaults IMAGE_REPO to the old
rosa-regional-platform-api image, so update the IMAGE_REPO header comment and
the IMAGE_REPO assignment in build-push-image.sh to the new repository name.
Make sure the default value used by the push logic matches the rename throughout
the script.
In `@cmd/rosa-hyperfleet-api/main.go`:
- Around line 73-76: The startup log message still uses the old service name, so
update the string in main.go where logger.Info is called to match the renamed
binary/module `rosa-hyperfleet-api`. Keep the rest of the log fields the same
and ensure any other startup or service-identifying messages in the entrypoint
use the new name for consistency.
In `@Makefile`:
- Around line 3-24: Update the remaining container image defaults in Makefile to
match the hyperfleet rename: IMAGE_REPO and CI_IMAGE_REPO still point to the old
rosa-regional-platform-api names. Change those defaults so the image build/push
targets and the CI lint container use the same renamed repository as BINARY_NAME
and REPO_URL, keeping the Makefile variables consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift-online/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e825bd7d-862c-476e-81eb-ba8d2fab8852
📒 Files selected for processing (71)
.gitignoreAGENTS.mdCLAUDE.mdDockerfileMakefileREADME.mdSECURITY-AUDIT.mdci/Containerfileci/build-push-image.shcmd/rosa-hyperfleet-api/main.gocmd/rosa-hyperfleet-api/main_test.godeployment/argocd/application-helm-hook.yamldeployment/argocd/application.yamldeployment/helm/rosa-hyperfleet-frontend/.helmignoredeployment/helm/rosa-hyperfleet-frontend/Chart.yamldeployment/helm/rosa-hyperfleet-frontend/README.mddeployment/helm/rosa-hyperfleet-frontend/templates/_helpers.tpldeployment/helm/rosa-hyperfleet-frontend/templates/configmap.yamldeployment/helm/rosa-hyperfleet-frontend/templates/deployment.yamldeployment/helm/rosa-hyperfleet-frontend/templates/post-sync-hook-job.yamldeployment/helm/rosa-hyperfleet-frontend/templates/post-sync-hook-rbac.yamldeployment/helm/rosa-hyperfleet-frontend/templates/service.yamldeployment/helm/rosa-hyperfleet-frontend/templates/serviceaccount.yamldeployment/helm/rosa-hyperfleet-frontend/templates/targetgroupbinding.yamldeployment/helm/rosa-hyperfleet-frontend/values.yamldeployment/helm/rosa-regional-frontend/Chart.yamldeployment/manifests/api.yamldocs/api/zoa-endpoints.mdgo.modinternal/test/thanos/helpers.gopkg/authz/authz.gopkg/authz/privileged/privileged.gopkg/authz/store/accounts.gopkg/authz/store/admins.gopkg/authz/store/groups.gopkg/authz/store/members.gopkg/clients/hyperfleet/client.gopkg/clients/hyperfleet/client_test.gopkg/clients/maestro/client.gopkg/clients/maestro/client_test.gopkg/config/config.gopkg/handlers/accounts.gopkg/handlers/authz.gopkg/handlers/cluster.gopkg/handlers/cluster_test.gopkg/handlers/management_cluster.gopkg/handlers/nodepool.gopkg/handlers/resource_bundle.gopkg/handlers/resource_bundle_test.gopkg/handlers/work.gopkg/handlers/work_test.gopkg/handlers/zoa.gopkg/handlers/zoa_test.gopkg/middleware/account_check.gopkg/middleware/admin_check.gopkg/middleware/admin_check_test.gopkg/middleware/authz.gopkg/middleware/privileged.gopkg/server/server.gopkg/server/server_test.gopkg/zoa/audit_store.gopkg/zoa/reconciler.gopkg/zoa/reconciler_test.gopkg/zoa/store.goscripts/run-e2e-authz.shtest/e2e-api/api_client.gotest/e2e-cli/cluster_test.gotest/e2e-platform-monitoring/logging_test.gotest/e2e-platform-monitoring/observability_test.gotest/e2e-platform-monitoring/suite_test.gotest/e2e-zoa/suite_test.go
💤 Files with no reviewable changes (1)
- deployment/helm/rosa-regional-frontend/Chart.yaml
| @@ -1,4 +1,4 @@ | |||
| # CI build-root image for rosa-regional-platform-api PR checks. | |||
| # CI build-root image for rosa-hyperfleet-api PR checks. | |||
There was a problem hiding this comment.
🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win
Header rename is fine; missing USER non-root directive (pre-existing).
Static analysis flags this image runs as root — no USER instruction is defined anywhere in the file. As per path instructions, Containerfiles should run as a non-root USER; never run as root. Consider adding a non-root USER even for this CI/lint image.
🧰 Tools
🪛 Trivy (0.69.3)
[error] 1-1: Image user should not be 'root'
Specify at least 1 USER command in Dockerfile with non-root user as argument
Rule: DS-0002
(IaC/Dockerfile)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ci/Containerfile` at line 1, The Containerfile currently defines no non-root
runtime user, so the image will run as root by default. Update the CI image
definition to add an explicit non-root USER instruction in the Containerfile,
placing it appropriately after any setup steps so the final image runs as a
restricted user instead of root.
Sources: Path instructions, Linters/SAST tools
| - Module path: `github.com/openshift/rosa-hyperfleet-api` | ||
| - Uses Ginkgo/Gomega for testing | ||
| - OpenAPI-first API design | ||
| - DynamoDB for data persistence |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Keep the generated guidance in sync.
CLAUDE.md still says DynamoDB for data persistence, which conflicts with the PostgreSQL backend documented in AGENTS.md and makes this auto-generated copy misleading.
Suggested fix
-- DynamoDB for data persistence
+- PostgreSQL for data persistence📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Module path: `github.com/openshift/rosa-hyperfleet-api` | |
| - Uses Ginkgo/Gomega for testing | |
| - OpenAPI-first API design | |
| - DynamoDB for data persistence | |
| - PostgreSQL for data persistence |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CLAUDE.md` around lines 46 - 49, Update the generated guidance in CLAUDE.md
so it matches the current backend description: replace the stale DynamoDB
persistence note with PostgreSQL, keeping the rest of the module guidance
unchanged. This is a documentation-only sync fix for the generated copy, so
adjust the persistence line near the module overview to align with AGENTS.md and
avoid conflicting guidance.
| name: rosa-hyperfleet | ||
| namespace: argocd | ||
| spec: | ||
| project: default | ||
| source: | ||
| repoURL: https://github.com/cdoan1/rosa-regional-platform-api | ||
| repoURL: https://github.com/cdoan1/rosa-hyperfleet-api | ||
| targetRevision: define-application-deployment | ||
| path: deployment/helm/rosa-regional-platform | ||
| path: deployment/helm/rosa-hyperfleet |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '## tracked files under deployment/argocd and deployment/helm\n'
git ls-files 'deployment/argocd/*' 'deployment/helm/*' | sed 's#^`#-` #'
printf '\n## directory listing for deployment/helm\n'
find deployment/helm -maxdepth 2 -type d | sort
printf '\n## application-helm-hook.yaml\n'
cat -n deployment/argocd/application-helm-hook.yaml
printf '\n## application.yaml\n'
cat -n deployment/argocd/application.yamlRepository: openshift-online/rosa-hyperfleet-api
Length of output: 3327
Update both ArgoCD source paths to the frontend chart
deployment/argocd/application-helm-hook.yaml and deployment/argocd/application.yaml still point at deployment/helm/rosa-hyperfleet, but the only chart in this repo is deployment/helm/rosa-hyperfleet-frontend. ArgoCD will fail to locate the chart until these paths are updated.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@deployment/argocd/application-helm-hook.yaml` around lines 4 - 11, The ArgoCD
application manifests are still referencing the old Helm chart path, so update
the source path in both application definitions to the frontend chart location.
In `application-helm-hook` and `application` under the ArgoCD manifests, change
the `source.path` value from the backend chart directory to
`deployment/helm/rosa-hyperfleet-frontend` so ArgoCD can locate the chart
correctly.
There was a problem hiding this comment.
This is a nice catch as well. Need to check
There was a problem hiding this comment.
@ravitri Sounds good — happy to help however needed. Just to summarize the concern: the path values in both deployment/argocd/application-helm-hook.yaml and deployment/argocd/application.yaml point to deployment/helm/rosa-hyperfleet, but the only chart present in the repo is deployment/helm/rosa-hyperfleet-frontend. If rosa-hyperfleet (backend) chart is intentionally missing and only the frontend chart exists so far, these paths will need to be updated to deployment/helm/rosa-hyperfleet-frontend (or a backend chart will need to be added later) before ArgoCD can sync successfully.
Let me know once you've confirmed the intended chart layout, and I can help verify the fix if needed.
| name: rosa-hyperfleet | ||
| namespace: argocd | ||
| spec: | ||
| project: default | ||
| source: | ||
| repoURL: https://github.com/openshift-online/rosa-regional-platform-api | ||
| repoURL: https://github.com/openshift-online/rosa-hyperfleet-api | ||
| targetRevision: main | ||
| path: deployment/helm/rosa-regional-platform | ||
| path: deployment/helm/rosa-hyperfleet |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'Top-level deployment paths:\n'
git ls-files 'deployment/**' | sed -n '1,200p'
printf '\nHelm chart files under deployment/helm:\n'
git ls-files 'deployment/helm/**' | sed -n '1,200p'
printf '\nApplication manifest:\n'
cat -n deployment/argocd/application.yamlRepository: openshift-online/rosa-hyperfleet-api
Length of output: 2910
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'Exists: deployment/helm/rosa-hyperfleet?\n'
[ -e deployment/helm/rosa-hyperfleet ] && echo yes || echo no
printf 'Exists: deployment/helm/rosa-hyperfleet-frontend?\n'
[ -e deployment/helm/rosa-hyperfleet-frontend ] && echo yes || echo no
printf '\nFiles in deployment/helm/rosa-hyperfleet-frontend (if any):\n'
find deployment/helm/rosa-hyperfleet-frontend -maxdepth 2 -type f 2>/dev/null | sort
printf '\nFiles in deployment/helm/rosa-hyperfleet (if any):\n'
find deployment/helm/rosa-hyperfleet -maxdepth 2 -type f 2>/dev/null | sort
printf '\napplication.yaml line(s):\n'
sed -n '1,30p' deployment/argocd/application.yamlRepository: openshift-online/rosa-hyperfleet-api
Length of output: 1152
Point ArgoCD at the actual chart directory
deployment/helm/rosa-hyperfleet does not exist; the chart lives at deployment/helm/rosa-hyperfleet-frontend, so this application will fail to sync until the path is updated.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@deployment/argocd/application.yaml` around lines 4 - 11, The ArgoCD
Application is pointing to a non-existent chart path, so update the source path
in the application spec to the actual Helm chart directory used by this app.
Locate the Application manifest under the spec.source configuration and change
the path from the old chart location to deployment/helm/rosa-hyperfleet-frontend
so ArgoCD can find and sync the chart successfully.
There was a problem hiding this comment.
This one too. We have deployment/helm/rosa-regional-frontend instead. Seems its better to keep this path as it is.
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== deployment/helm listing =="
git ls-files 'deployment/helm/**' | sort
echo
echo "== application.yaml current content =="
cat -n deployment/argocd/application.yaml
echo
echo "== application-helm-hook.yaml current content =="
cat -n deployment/argocd/application-helm-hook.yamlLength of output: 3356
@ravitri Thanks for weighing in! I double-checked the current state of the PR branch, and here's what I found:
$ git ls-files 'deployment/helm/**'
deployment/helm/rosa-hyperfleet-frontend/Chart.yaml
deployment/helm/rosa-hyperfleet-frontend/README.md
deployment/helm/rosa-hyperfleet-frontend/templates/...
deployment/helm/rosa-hyperfleet-frontend/values.yaml
...
deployment/helm/rosa-regional-frontend no longer exists on this branch — this PR itself renames it to deployment/helm/rosa-hyperfleet-frontend (the diff shows deployment/helm/rosa-regional-frontend/Chart.yaml deleted and deployment/helm/rosa-hyperfleet-frontend/Chart.yaml added).
So regardless of whether the path in application.yaml is left as deployment/helm/rosa-hyperfleet or changed, it still won't match any directory that exists after this PR merges — the only chart directory present is deployment/helm/rosa-hyperfleet-frontend. If ArgoCD tries to sync this application against this repo/branch, it will fail to find the chart either way.
That said, if this Application manifest isn't actively used yet (e.g., it's a placeholder for future GitOps wiring, or the real path will be fixed in a follow-up PR), it's reasonable to leave it as-is for now. Just flagging so it's not forgotten before this gets applied to a live ArgoCD instance.
Let me know if you'd like me to open a follow-up issue to track fixing the Argo CD Application path(s) once the Helm chart location is finalized.
| helm install rosa-hyperfleet ./deployment/helm/rosa-hyperfleet \ | ||
| --namespace rosa-hyperfleet \ |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Install path doesn't match this chart's own directory.
This README lives at deployment/helm/rosa-hyperfleet-frontend/README.md, but the install command references ./deployment/helm/rosa-hyperfleet (missing -frontend). Same discrepancy affects the ArgoCD application.yaml/application-helm-hook.yaml source.path.
🔧 Proposed fix
-helm install rosa-hyperfleet ./deployment/helm/rosa-hyperfleet \
+helm install rosa-hyperfleet ./deployment/helm/rosa-hyperfleet-frontend \📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| helm install rosa-hyperfleet ./deployment/helm/rosa-hyperfleet \ | |
| --namespace rosa-hyperfleet \ | |
| helm install rosa-hyperfleet ./deployment/helm/rosa-hyperfleet-frontend \ | |
| --namespace rosa-hyperfleet \ |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@deployment/helm/rosa-hyperfleet-frontend/README.md` around lines 27 - 28, The
install command and ArgoCD source paths are pointing at the wrong chart
directory. Update the references in the README and the related application
manifests so they use the same chart folder as this component, not the
non-frontend path. Use the existing chart-specific symbols and paths in the
README, application.yaml, and application-helm-hook.yaml to ensure all installs
and syncs target the frontend chart consistently.
| name: rosa-regional-platform | ||
| name: rosa-hyperfleet | ||
| image: | ||
| repository: quay.io/cdoan0/rosa-regional-platform-api |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Image repository still references the old name.
app.image.repository is quay.io/cdoan0/rosa-regional-platform-api, not renamed to rosa-hyperfleet-api, mirroring the same stale reference in deployment/manifests/api.yaml Line 150.
🔧 Proposed fix
- repository: quay.io/cdoan0/rosa-regional-platform-api
+ repository: quay.io/cdoan0/rosa-hyperfleet-api📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| repository: quay.io/cdoan0/rosa-regional-platform-api | |
| repository: quay.io/cdoan0/rosa-hyperfleet-api |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@deployment/helm/rosa-hyperfleet-frontend/values.yaml` at line 16, The
app.image.repository value still points to the old rosa-regional-platform-api
image, so update the repository reference to the renamed rosa-hyperfleet-api in
the Helm values and keep it consistent with the image reference used by the API
manifest. Check the app.image.repository setting in values.yaml and the
corresponding image repository field in deployment/manifests/api.yaml so both
point to the new repository name.
| name: rosa-hyperfleet | ||
| namespace: rosa-hyperfleet | ||
| labels: | ||
| app: rosa-regional-platform | ||
| app: rosa-hyperfleet | ||
| spec: | ||
| replicas: 1 | ||
| selector: | ||
| matchLabels: | ||
| app: rosa-regional-platform | ||
| app: rosa-hyperfleet | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app: rosa-regional-platform | ||
| app: rosa-hyperfleet | ||
| spec: | ||
| containers: | ||
| # ================================================================= | ||
| # Main application container | ||
| # ================================================================= | ||
| - name: rosa-regional-platform | ||
| - name: rosa-hyperfleet | ||
| image: quay.io/cdoan0/rosa-regional-platform-api:latest |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Container image still references the old repo name.
Deployment identity (name/namespace/labels/container name) is renamed to rosa-hyperfleet, but the container image at Line 150 still points at quay.io/cdoan0/rosa-regional-platform-api:latest. Same stale reference exists in deployment/helm/rosa-hyperfleet-frontend/values.yaml Line 16.
🔧 Proposed fix
- image: quay.io/cdoan0/rosa-regional-platform-api:latest
+ image: quay.io/cdoan0/rosa-hyperfleet-api:latest📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| name: rosa-hyperfleet | |
| namespace: rosa-hyperfleet | |
| labels: | |
| app: rosa-regional-platform | |
| app: rosa-hyperfleet | |
| spec: | |
| replicas: 1 | |
| selector: | |
| matchLabels: | |
| app: rosa-regional-platform | |
| app: rosa-hyperfleet | |
| template: | |
| metadata: | |
| labels: | |
| app: rosa-regional-platform | |
| app: rosa-hyperfleet | |
| spec: | |
| containers: | |
| # ================================================================= | |
| # Main application container | |
| # ================================================================= | |
| - name: rosa-regional-platform | |
| - name: rosa-hyperfleet | |
| image: quay.io/cdoan0/rosa-regional-platform-api:latest | |
| name: rosa-hyperfleet | |
| namespace: rosa-hyperfleet | |
| labels: | |
| app: rosa-hyperfleet | |
| spec: | |
| replicas: 1 | |
| selector: | |
| matchLabels: | |
| app: rosa-hyperfleet | |
| template: | |
| metadata: | |
| labels: | |
| app: rosa-hyperfleet | |
| spec: | |
| containers: | |
| # ================================================================= | |
| # Main application container | |
| # ================================================================= | |
| - name: rosa-hyperfleet | |
| image: quay.io/cdoan0/rosa-hyperfleet-api:latest |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@deployment/manifests/api.yaml` around lines 131 - 150, The container image
reference is still using the old repository name, so update the image value in
the rosa-hyperfleet deployment spec to point to the new rosa-hyperfleet image
instead of the stale quay.io/cdoan0/rosa-regional-platform-api:latest reference;
make the same repository rename in the corresponding frontend Helm values entry
so the deployment and chart stay consistent. Locate and fix the image fields
under the rosa-hyperfleet container configuration and the
rosa-hyperfleet-frontend values to remove the old repo name entirely.
| Tests compatibility by spinning up an ephemeral [rosa-hyperfleet](https://github.com/openshift-online/rosa-hyperfleet) environment with the platform-api image from the PR, then running the rosa-hyperfleet test suite against it using the commit hash of the PR. | ||
|
|
||
| **Trigger:** `/test rosa-regionality-compatibility-e2e` (does not run automatically). | ||
|
|
||
| **Configuration:** Defined in [openshift/release](https://github.com/openshift/release) under `ci-operator/config/openshift-online/rosa-regional-platform-api/`. | ||
| **Configuration:** Defined in [openshift/release](https://github.com/openshift/release) under `ci-operator/config/openshift-online/rosa-hyperfleet-api/`. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use the current API branding in the CI blurb.
platform-api image is stale wording here and makes the Prow job description inconsistent with the rename.
Suggested fix
- Tests compatibility by spinning up an ephemeral [rosa-hyperfleet](https://github.com/openshift-online/rosa-hyperfleet) environment with the platform-api image from the PR, then running the rosa-hyperfleet test suite against it using the commit hash of the PR.
+ Tests compatibility by spinning up an ephemeral [rosa-hyperfleet](https://github.com/openshift-online/rosa-hyperfleet) environment with the current API image from the PR, then running the test suite against it using the commit hash of the PR.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Tests compatibility by spinning up an ephemeral [rosa-hyperfleet](https://github.com/openshift-online/rosa-hyperfleet) environment with the platform-api image from the PR, then running the rosa-hyperfleet test suite against it using the commit hash of the PR. | |
| **Trigger:** `/test rosa-regionality-compatibility-e2e` (does not run automatically). | |
| **Configuration:** Defined in [openshift/release](https://github.com/openshift/release) under `ci-operator/config/openshift-online/rosa-regional-platform-api/`. | |
| **Configuration:** Defined in [openshift/release](https://github.com/openshift/release) under `ci-operator/config/openshift-online/rosa-hyperfleet-api/`. | |
| Tests compatibility by spinning up an ephemeral [rosa-hyperfleet](https://github.com/openshift-online/rosa-hyperfleet) environment with the current API image from the PR, then running the test suite against it using the commit hash of the PR. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` around lines 403 - 407, The CI blurb in the README still refers to
the old “platform-api image” wording, which is inconsistent with the current
branding. Update the compatibility test description near the
rosa-regionality-compatibility-e2e section to use the current API name
consistently, keeping the rest of the trigger and configuration text unchanged.
|
/hold Reviews are welcome but meanwhile, addressing other points in review so far |
openshift-ci
Bot
added
the
do-not-merge/hold
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Will handle the rebase for this PR once #121 is merged as well |
|
@ravitri: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
This PR updates references from
rosa-regional-platform-apitorosa-hyperfleet-api.Similar to PR openshift-online/rosa-hyperfleet#665
Summary by CodeRabbit
New Features
Bug Fixes
Documentation