Add diagnostic logging for slow healthcheck DB queries - #515
Draft
patilsuraj767 wants to merge 1 commit into
Draft
Add diagnostic logging for slow healthcheck DB queries#515patilsuraj767 wants to merge 1 commit into
patilsuraj767 wants to merge 1 commit into
Conversation
Signed-off-by: Suraj Patil <Suraj Patil>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Is there an associated Jira issue for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The healthcheck handler's DB call (instanceDao.Get) can exceed the Kubernetes probe timeout (default 1s), causing liveness/readiness probe failures. Use a detached context for the DB query so it runs to completion even after the kubelet disconnects, and log the actual query duration when the probe connection is outlasted. Skip writing the HTTP response when the client is already gone to avoid broken pipe errors.