Skip to content

chore(deps): bump OpenShell to v0.1.6-rhaiv.1 - #845

Open
hypershell-builder[bot] wants to merge 1 commit into
mainfrom
implementer/update-openshell-v0.1.6-rhaiv.1
Open

hypershell-builder[bot] wants to merge 1 commit into
mainfrom
implementer/update-openshell-v0.1.6-rhaiv.1

Conversation

@hypershell-builder

Copy link
Copy Markdown
Contributor

Summary

This change moves HyperShell's pinned OpenShell gateway from v0.1.5-rhaiv.3
to v0.1.6-rhaiv.1, the newest stable midstream release. It updates image
tags, vendors the matching Helm chart, and updates version citations in specs
and skill docs. It does not change control-plane behavior.

This replaces PR #810 and PR #822

Two OpenShell update PRs were already open when this run started:

Comparing v0.1.6-rhaiv.0...v0.1.6-rhaiv.1 on opendatahub-io/openshell
shows only 5 dependency-bump commits (rustls, RPM lockfile refresh) - the
NVIDIA base version did not change, so every finding in PR #822's triage
still applies and was re-checked directly against the v0.1.6-rhaiv.1
chart rather than re-derived from scratch. Please close #810 and #822 once
this PR is reviewed; this agent does not close or merge pull requests.

What changed

  • Bumped OPENSHELL_TAG in OPENSHELL_VERSION and ran the standard pin sync
    (deploy/base/platform-resources/controller.yaml,
    deploy/ibm/kustomization.yaml).
  • Vendored charts/openshell/ from the v0.1.6-rhaiv.1 tag. The chart adds
    an experimental shared-supervisor high-availability pool
    (supervisor_topology = "gateway"); it is off by default and HyperShell
    does not opt in, so it renders nothing for HyperShell's deployments.
  • Updated the matching tag string in the ROKS e2e script, the CLI e2e image
    pin, the IBM ROKS mirror commands, and spec/skill doc examples.
  • Recovered a spec fix that was drafted in PR chore(deps): bump OpenShell to v0.1.5-rhaiv.4 #810 but never merged: added a
    "Known gap" note to openshell-gateway.spec.md's Auth Section documenting
    the still-open auth-startup issue below, so the gap is visible in the spec
    and not only in an issue thread.
  • Ran all Python policy checks that make up make check directly (the agent
    runtime cannot invoke make itself); all pass. go build/vet/test could
    not run in this runtime (no Go toolchain) - the only changed .go file is
    a single string-literal image-tag edit in tests/e2e/cli_test.go; this is
    a recorded gap for CI or a human reviewer to confirm, not a known break.

Release-note triage

Needs a maintainer decision (already tracked, not fixed here)

Issue #809 tracks a change that first appeared in v0.1.5-rhaiv.4 and is
still present in v0.1.6-rhaiv.1: the gateway now refuses to start - before
it opens any network port - if no OIDC, mTLS, operator auth, or
gateway_jwt is configured and allow_unauthenticated_users is not set to
true (NVIDIA/OpenShell#4821). HyperShell's own config check
(ValidateRenderedGatewayConfig) still accepts that setup as valid today,
and the control plane can produce it for a gateway reconciled while Keycloak
integration is off and no custom OIDC issuer is set. After this bump, such a
gateway will crash-loop at startup instead of running insecurely as before.
This PR does not change that behavior; #809 remains open for a maintainer
decision.

Verify before the next live deployment (not fixed here)

Starting in v0.1.6-rhaiv.0, new sandboxes on the Kubernetes, Docker,
Podman, and VM drivers open their control connection to the supervisor,
reversing the old direction where the supervisor connected to the sandbox
(NVIDIA/OpenShell#4656; already-running sandboxes keep the old direction
through the upgrade). HyperShell's openshell-gateway-allow-sandbox
NetworkPolicy already allows sandbox pods to reach the gateway pod, and the
chart's sandbox NetworkPolicy only ever restricted traffic into sandbox
pods, never outbound traffic from them, so nothing in the current
NetworkPolicy set should block this. The exact port was not confirmed from
static review alone. Flagging this for verification on the next Kind or
ROKS deployment; no NetworkPolicy change is made in this PR.

Additive or inert, no action needed

  • The experimental shared-supervisor high-availability pool (replicas,
    autoscaling, pod-disruption budget, a new NetworkPolicy) and an
    operator-owned additional-CA trust bundle for sandbox supervisors. Both
    are off unless HyperShell explicitly opts in, which it does not.
  • A field in an internal compute-driver message was renamed
    (ResumeBoundaryRequest). This only affects external compute-driver
    plugins; HyperShell uses the built-in Kubernetes driver.
  • The gateway now writes its own audit log entries for authorization and
    credential events. This needs no configuration from HyperShell.
  • A new optional hostname format for exposed sandbox services defaults to
    the existing readable format, so current behavior is unchanged.
  • Two new optional Helm values (server.extraEnv,
    pkiInitJob.podLabels/podAnnotations). Not adopted.
  • The chart's RBAC grants (namespaces, tokenreviews, nodes, runtimeclasses,
    priorityclasses, pods, events, services, networkpolicies, secrets,
    serviceaccounts, PVCs, sandboxes) are all already present in
    controller-rbac.yaml. No RBAC change was needed.

Console dashboard: unchanged

The console dashboard image stays pinned to its current release. No .proto
file changed upstream between v0.1.5-rhaiv.3 and v0.1.6-rhaiv.1, so the
console digest stays as-is.

Sandbox API version: unchanged

agents.x-k8s.io/v1beta1 is still the primary Agent Sandbox API version the
vendored chart requires, with v1alpha1 as a preflight fallback.

Files changed

  • OPENSHELL_VERSION, deploy/base/platform-resources/controller.yaml,
    deploy/ibm/kustomization.yaml - pin sync
  • charts/openshell/ - vendored Helm chart at v0.1.6-rhaiv.1
  • components/pr-test/e2e-openshell-roks.sh, tests/e2e/cli_test.go - e2e
    image pins
  • specs/platform/{data-model,openshell-gateway, openshell-image-auto-update}.spec.md - version citations and the
    recovered Auth Section "Known gap" note
  • skills/deploy/{deploy-cluster,gcp-cluster,ibm-cluster}/SKILL.md - example
    image pins and ROKS mirror commands
  • skills/tooling/update-openshell/SKILL.md - Learnings log entry

Test plan

  • All runnable make check sub-checks (Python policy scripts and their
    unit tests) pass directly
  • Confirmed the new chart's RBAC grants are all already covered by
    controller-rbac.yaml; no escalation
  • Confirmed the config-schema, console-image, and Sandbox-API-version
    findings from PR chore(deps): bump OpenShell to v0.1.6-rhaiv.0 #822 still hold against the v0.1.6-rhaiv.1 chart
  • Full-repo grep confirms no stray old-version string remains outside
    intentional fixtures and historical log entries
  • go build/vet/test - could not run in this agent runtime (no Go
    toolchain); please confirm in CI
  • Live cluster validation (Kind or ROKS) of the new gateway image,
    including the sandbox control-connection direction change above, is
    still needed

🤖 Generated with Claude Code

Moves HyperShell's pinned OpenShell gateway from v0.1.5-rhaiv.3 to
v0.1.6-rhaiv.1, the newest stable midstream release, and vendors the
matching Helm chart. Supersedes the stale PR 810 (v0.1.5-rhaiv.4) and
PR 822 (v0.1.6-rhaiv.0): the v0.1.6-rhaiv.0..v0.1.6-rhaiv.1 delta is
dependency-only (rustls, RPM lockfile refresh), so 822's triage was
re-verified against this tag rather than redone. Also folds back a
gateway-spec Auth Section note (drafted in 810 but never merged) that
documents the still-open issue 809 gap.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@hypershell-builder hypershell-builder Bot added the agent/reviewable-code Code changes awaiting review label Oct 30, 2026
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

HyperShell environment destroyed

This ephemeral OpenShift environment has been destroyed. Comment /pr-extend to redeploy it.

@codecov-appsre

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main     #845   +/-   ##
=======================================
  Coverage   44.82%   44.82%           
=======================================
  Files         386      386           
  Lines       30412    30412           
=======================================
+ Hits        13631    13633    +2     
+ Misses      15053    15051    -2     
  Partials     1728     1728           
Flag Coverage Δ
control-plane 55.52% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15397da...31e9aca. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent/reviewable-code Code changes awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants