Skip manual access checks when DocRequest-based authz is active#1209
Merged
joshuali925 merged 1 commit intoJul 22, 2026
Merged
Conversation
With request classes implementing DocRequest, the security plugin enforces resource-sharing authz before the transport action runs. Guard the legacy UserAccessManager.doesUserHasAccess calls behind !shouldUseResourceAuthz so they only apply in the pre-resource-sharing backend-role path, avoiding a duplicate (and inconsistent) check when resource sharing is enabled. Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
force-pushed
the
onboard-doc-request-authz
branch
from
July 22, 2026 21:51
f3390f7 to
9267e96
Compare
DarshitChanpura
marked this pull request as ready for review
July 22, 2026 22:02
DarshitChanpura
requested review from
Swiddis,
YANG-DB,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48 and
seankao-az
as code owners
July 22, 2026 22:02
joshuali925
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With request classes implementing DocRequest, the security plugin enforces resource-sharing authz before the transport action runs. Guard the legacy UserAccessManager.doesUserHasAccess calls behind !shouldUseResourceAuthz so they only apply in the pre-resource-sharing backend-role path, avoiding a duplicate (and inconsistent) check when resource sharing is enabled.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.