[Backport 3.5] fix: Accept nullable ResourceSharingClient to prevent NPE on feature disable(#1204)#1207
Draft
DarshitChanpura wants to merge 1 commit into
Draft
Conversation
…disable (opensearch-project#1204) When the resource-sharing feature flag is disabled via cluster settings, the security plugin calls assignResourceSharingClient(null) on all registered ResourceSharingExtension implementations to clear the client. The Kotlin non-null parameter declaration causes an immediate NPE in ClusterApplierService.applyChanges(), preventing cluster state from being published to follower nodes. The master steps down and re-election hits the same failure, creating an infinite election loop. Fix: Change parameter types to nullable (ResourceSharingClient?) in both ReportsSchedulerExtension and ResourceSharingClientAccessor. The internal field was already declared nullable and getResourceSharingClient() already returns nullable, so all callers handle null correctly. Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
changed the title
joshuali925
approved these changes
Jul 13, 2026
ps48
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #1204 to 3.5
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.