chore(deps): pin dompurify, js-yaml, postcss-selector-parser in starlight-docs - #361
Open
kylehounslow wants to merge 1 commit into
Open
Conversation
…ight-docs Clears CVEs in the docs/starlight-docs lockfile via package.json overrides, all within existing majors: - dompurify 3.4.5 -> 3.4.12 (CVE-2026-49978 CRITICAL 9.3, +8 more, via mermaid) - js-yaml 4.1.1 -> 4.3.0 (CVE-2026-59869 7.5, CVE-2026-53550 5.3, via @astrojs/starlight) - postcss-selector-parser 6.1.2 -> 6.1.4 (CVE-2026-9358 4.3, via postcss-nested) postcss-selector-parser is a transitive dep of postcss-nested (^6.1.1); a lockfile refresh alone keeps it at 6.1.2, so it needs an explicit override. CVE-2026-9358's fix was backported to 6.1.3, so ^6.1.3 clears it. Closes opensearch-project#258, closes opensearch-project#278 Signed-off-by: Kyle Hounslow <kylehounslow@users.noreply.github.com>
kylehounslow
requested review from
anirudha,
goyamegh,
joshuali925,
ps48 and
vamsimanohar
as code owners
July 27, 2026 20:43
This was referenced Jul 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage 55.62% 55.62%
=======================================
Files 4 4
Lines 169 169
Branches 47 48 +1
=======================================
Hits 94 94
Misses 74 74
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pins three vulnerable transitive dependencies in the
docs/starlight-docslockfile viapackage.jsonoverrides. All three bumps stay within their existing majors.Source alert: #357 (starlight-docs section). Tracking alerts: #258 (mermaid: dompurify, 9 CVEs, highest 9.3) and #278 (starlight: js-yaml + postcss-selector-parser, highest 7.5).
Why overrides
dompurify and js-yaml resolve one lockfile refresh away from their patched versions, but
postcss-selector-parseris a transitive dep ofpostcss-nested(^6.1.1);npm install --package-lock-onlyalone keeps it pinned at 6.1.2. An explicitoverridesentry is required to move it. Per the CVE-2026-9358 advisory the fix was backported to the 6.x line in 6.1.3, so^6.1.3(resolving to 6.1.4) clears it without a major bump. The other two are placed in the sameoverridesblock so the intended floor is auditable in the manifest, not only in the lockfile.The astro-7 / starlight-0.41 supersets (#336, #356) are intentionally excluded; the astro v7 evaluation is tracked separately (#340, #327).
Validation
Mirrors
docs-ci.yml, Node 22:npm ci && npm run build(starlight): green, 135 pages, all internal links valid.<pre class="mermaid">, and the bundleddist/_astro/mermaid.core.*.jsships DOMPurify3.4.12. dompurify is mermaid's XSS sanitizer, so this confirms the patched sanitizer reaches the built output, not just the lockfile.npm audit --omit=dev: dompurify, js-yaml, and postcss-selector-parser all clear. Remaining audit entries (astro, esbuild, postcss, sharp, svgo, vite) are out of scope for this alert.npm ls dompurify js-yaml postcss-selector-parser: all three reportoverriddenat the patched versions.Closes #258, closes #278