chore(deps): bump docs deps to clear astro/vite/tar/undici/babel CVEs (#357) - #360
Open
kylehounslow wants to merge 2 commits into
Open
chore(deps): bump docs deps to clear astro/vite/tar/undici/babel CVEs (#357)#360kylehounslow wants to merge 2 commits into
kylehounslow wants to merge 2 commits into
Conversation
kylehounslow
requested review from
anirudha,
goyamegh,
joshuali925,
ps48 and
vamsimanohar
as code owners
July 27, 2026 20:35
This was referenced Jul 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
=======================================
Coverage 55.62% 55.62%
=======================================
Files 4 4
Lines 169 169
Branches 47 47
=======================================
Hits 94 94
Misses 74 74
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Manifest docs (docs/package.json + lockfile): - astro ^6.1.6 -> ^6.4.6 (resolves 6.4.8). Clears CVE-2026-54299, CVE-2026-54298 (fixed in astro 6.4.6, within 6.x). - vite pinned to ^7.3.6 via astro and @astrojs/react overrides. astro 6.4.x requires vite ^7.3.2 which resolved 7.3.3, below the fixed floor. Clears GHSA-fx2h-pf6j-xcff, GHSA-v6wh-96g9-6wx3. - tar override ^7.5.22, undici override raised ^7.24.0 -> ^7.29.0. Clears the astro-icon build-time chain (undici GHSA-38rv-x7px-6hhq and related, tar). - js-yaml override ^4.3.0 (astro transitive). - @babel/core override ^7.29.6 (@astrojs/react transitive, resolves 7.29.7). extract-zip vulnerable child yauzl already overridden to ^3.2.1 (resolves 3.4.0); extract-zip no longer flagged. Remaining docs advisories (astro <=7.0.9 and its nested esbuild/sharp) require the astro 7 major and are intentionally left open. Tracked via the astro-7 follow-up. Refs opensearch-project#357 Signed-off-by: Kyle Hounslow <kylhouns@amazon.com>
kylehounslow
force-pushed
the
deps/docs-cve-astro-6.4.6
branch
from
July 27, 2026 20:51
1885367 to
901bfad
Compare
The "should have title with correct styling" property test omitted the character-exclusion filters its sibling tests apply. Under fast-check seed 1813198527 it generated a link containing a double-quote, which corrupted the href attribute in the raw-string card render, so .use-case-title resolved to null and the assertion failed. Align its link and description generators with the other tests in the file. Signed-off-by: Kyle Hounslow <kylhouns@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clears the high and moderate CVEs on the
docs/manifest (docs/package.json+docs/package-lock.json), staying within astro 6.x. Does not touchdocs/starlight-docs(out of scope for this PR).Changes
docs/package.json:astro^6.1.6->^6.4.6(resolves 6.4.8)overrides: raiseundici^7.24.0->^7.29.0; addtar^7.5.22,js-yaml^4.3.0,@babel/core^7.29.6; add scopedvite^7.3.6underastroand@astrojs/reactResolved versions: astro 6.4.8, vite 7.3.6 (single deduped copy), tar 7.5.22, undici 7.29.0, js-yaml 4.3.0, @babel/core 7.29.7, yauzl 3.4.0 (via the existing override), postcss 8.5.23.
CVEs closed
server.fs.denybypass), GHSA-v6wh-96g9-6wx3 (launch-editor NTLMv2 disclosure)yauzlwas already overridden to^3.2.1; extract-zip is no longer flaggedWhy the vite override
astro 6.4.x requires
vite ^7.3.2, which resolves to 7.3.3, below the 7.3.6 fixed floor. A lockfile-only bump would regress on the next dependabot regen, so the fix is pinned inoverridesscoped to astro and@astrojs/react. The top-level vite (via@tailwindcss/vite) stays on the 8.x line, above the fixed floor. No global vite override, so the 8.x tree is not downgraded.Left open (astro 7 only)
Five advisories remain and require the astro 7 major, out of scope for this non-breaking pass: GHSA-4g3v-8h47-v7g6, GHSA-7pw4-f3q4-r2p2, GHSA-f48w-9m4c-m7f5, plus astro's nested esbuild (GHSA-g7r4-m6w7-qqqr) and sharp (GHSA-f88m-g3jw-g9cj). Note: GHSA-f48w-9m4c-m7f5 is a distinct follow-up advisory (range
<7.0.6) whose title reads "incomplete fix for CVE-2026-54298"; the original CVE-2026-54298 is cleared by 6.4.6. Tracked separately for the astro 7 major upgrade.Validation
Mirrors
docs-ci.yml:npm ciclean (lockfile in sync with manifest)npm run build:mainsucceeds on astro 6.4.8 / vite 7.3.6npm run test:coverage: 557 passednpm audit --omit=dev: 3 vulnerabilities remain, all the astro-7-only advisories aboveCI (ubuntu-latest) runs the native rollup path.
Refs #357