[Breaking Change] Corrects the security config constant name which uses trusted cas#513
Open
DarshitChanpura wants to merge 1 commit into
Open
Conversation
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
force-pushed
the
correct-security-constant
branch
from
August 30, 2023 19:18
99db999 to
7e666e0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
============================================
- Coverage 74.60% 74.50% -0.11%
+ Complexity 868 866 -2
============================================
Files 130 130
Lines 5632 5632
Branches 689 689
============================================
- Hits 4202 4196 -6
- Misses 1124 1129 +5
- Partials 306 307 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DarshitChanpura
marked this pull request as ready for review
August 30, 2023 19:35
DarshitChanpura
requested review from
AWSHurneyt,
bowenlan-amzn,
eirsep,
getsaurabh02,
lezzago,
qreshi,
rishabhmaurya,
sbcd90 and
tlfeng
as code owners
August 30, 2023 19:35
lezzago
reviewed
Aug 30, 2023
|
|
||
| // These reside in security plugin. | ||
| public static final String OPENSEARCH_SECURITY_SSL_HTTP_PEMCERT_FILEPATH = "plugins.security.ssl.http.pemcert_filepath"; | ||
| public static final String OPENSEARCH_SECURITY_SSL_HTTP_PEMTRUSTEDCAS_FILEPATH = "plugins.security.ssl.http.pemtrustedcas_filepath"; |
Member
There was a problem hiding this comment.
If we go ahead with this breaking change, there should be issues created to each of the plugins that use this constant about this breaking change.
Affected plugins: https://github.com/search?q=org%3Aopensearch-project%20%22OPENSEARCH_SECURITY_SSL_HTTP_PEMCERT_FILEPATH%22&type=code
Member
There was a problem hiding this comment.
Also is it necessary to have a variable name change here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SecureRestClientBuilder currently is using node-certificate constant
pemcert_filepathto build trust store. This is incorrect. It should be usingpemtrustedcas_filepathto build a trust-store with root CAsIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.