Reject explicitly empty index store type - #22551
Open
HUSTERGS wants to merge 2 commits into
Open
Conversation
Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
HUSTERGS
requested review from
a team,
Bukhtawar,
alchemist51,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
July 23, 2026 08:25
Contributor
PR Reviewer Guide 🔍(Review updated until commit 0c7ecbe)Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨ |
Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Contributor
|
Persistent review updated to latest commit 0c7ecbe |
Contributor
|
❌ Gradle check result for 0c7ecbe: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explicitly setting
index.store.typeto an empty string currently bypasses the registered directory factory lookup. The create-index request is acknowledged, but shard creation later fails withno matching store type for [], leaving the index red.This change distinguishes an omitted store type from an explicitly configured empty value:
index.store.typeis absent, the internal empty default continues to select the default directory factory.index.store.typeis explicitly set to"", it enters the existing directory factory lookup and fails withIllegalArgumentException: Unknown store type [].The failure occurs while creating the temporary
IndexService, before the index is added to the cluster state.This change adds an internal-cluster test verifying that an explicitly empty store type is rejected during index creation.
Validation performed:
Related Issues
Resolves #22550
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.