Skip to content

Dependencies#50

Merged
alirezazolanvari merged 7 commits into
devfrom
dependencies
Jul 24, 2026
Merged

Dependencies#50
alirezazolanvari merged 7 commits into
devfrom
dependencies

Conversation

@sepandhaghighi

Copy link
Copy Markdown
Member

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • Dependencies structure modified

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this Jun 29, 2026
@sepandhaghighi sepandhaghighi added test dependencies Pull requests that update a dependency file labels Jun 29, 2026
@sepandhaghighi sepandhaghighi added this to the drux v0.5 milestone Jun 29, 2026
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (222d819) to head (b66b866).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #50   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files           9        9           
  Lines         235      235           
  Branches       26       26           
=======================================
  Hits          232      232           
  Misses          2        2           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi
sepandhaghighi marked this pull request as ready for review June 30, 2026 20:21

@alirezazolanvari alirezazolanvari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts. I just asked a question. Other than that, everything else looks fine to me.

Comment thread setup.py
from distutils.core import setup


def get_requires() -> list:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure why this function was removed. Could you please explain why this change is necessary? Without it, adding each dependency is going to be a hassle since it needs to be updated in several places.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed about this topic in our previous weekly session, it seems that it's better to move all required dependencies to setup.py to make the project independent from any external text file.

@alirezazolanvari
alirezazolanvari merged commit 6cb9dd5 into dev Jul 24, 2026
25 checks passed
@alirezazolanvari
alirezazolanvari deleted the dependencies branch July 24, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants