You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❌ Patch coverage is 90.99099% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.12%. Comparing base (0e582b3) to head (6dc9537). ⚠️ Report is 1 commits behind head on dev.
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.
@sepandhaghighi, I revised the changes that were proposed in this PR. The summary of changes and the main idea/motivation behind them are presented below. It might look like more than a single PR, so feel free to let me know to split it into different PRs.
New Architecture
Motivation
Keeping registry info of all the models centralized to be able to build on it for future developments.
File Overview
File
Role
Key Exports
registry.py
Single source of truth: equations, params, validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
params.pyabstractmethods inDrugReleaseModelusing configs from models registries1for the Entire releasable amount (M_0/M) in the respective modelsblack