feat: student enrollment nd attendance improvement - #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the Subject Enrollment feature to the admin portal and improves the student and attendance workflows, along with a few fixes found while testing.
What's new / changed:
Type of change
Affected areas
backend/)frontend/)backend/db/migrations/)How was this tested?
go build ./...passes.pnpm lintandpnpm buildpass.Checklist
go build ./...passes (nogo test— the project has no test suite yet)pnpm lintandpnpm buildpasssqlc generateafter editing queries/migrations — not run yet; the generated files were hand-synced to match, please runsqlc generateto confirm before mergebackend/db/sqlc/were hand-edited — generated files were hand-synced forattendance.sql.go,students.sql.go, andquerier.goas a stopgap; runningsqlc generateshould reproduce them identicallyNotes for reviewer
000012re-pointsattendance_sessions.taken_bytousers(id); it runs automatically on server startup./me, so the localuserstable isn't always in sync with Asgardeo. Attendance now self-provisions the acting user to work around this — worth a follow-up to sync users centrally.