更新: 新增xml转tdml的测试版本 - #38
Open
Camber-ux wants to merge 2 commits into
Open
Conversation
photonbit
suggested changes
May 12, 2026
photonbit
left a comment
photonbit
left a comment
Contributor
There was a problem hiding this comment.
Hello, I added comments for the changes of the emptiness check functions. They are no longer checking for empty values, so I think the functions should be removed or renamed.
| return True | ||
| else: | ||
| return False | ||
| return False |
Contributor
There was a problem hiding this comment.
This function change no longer qualifies it to be named in the same way, as it is not checking for emptiness
|
|
||
|
|
||
| def remove_empty_values(d): | ||
| if isinstance(d, dict): |
Contributor
There was a problem hiding this comment.
This function is no longer checking if there are empty values, the semantics have change. If I understand correctly, the current function will return "d" as it was originally, but traversing all the elements inside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.